projects
/
freeside.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (from parent 1:
201c446
)
some cleanup while i'm here
author
ivan
<ivan>
Wed, 13 Sep 2006 14:53:01 +0000
(14:53 +0000)
committer
ivan
<ivan>
Wed, 13 Sep 2006 14:53:01 +0000
(14:53 +0000)
FS/FS/cust_credit.pm
patch
|
blob
|
history
FS/FS/cust_pay.pm
patch
|
blob
|
history
diff --git
a/FS/FS/cust_credit.pm
b/FS/FS/cust_credit.pm
index
9cc92d2
..
7ffb1d1
100644
(file)
--- a/
FS/FS/cust_credit.pm
+++ b/
FS/FS/cust_credit.pm
@@
-134,10
+134,13
@@
sub insert {
=item delete
=item delete
-Currently unimplemented.
+Unless the closed flag is set, deletes this credit and all associated
+applications (see L<FS::cust_credit_bill>). In most cases, you want to use
+the void method instead to leave a record of the deleted credit.
=cut
=cut
+# very similar to FS::cust_pay::delete
sub delete {
my $self = shift;
return "Can't delete closed credit" if $self->closed =~ /^Y/i;
sub delete {
my $self = shift;
return "Can't delete closed credit" if $self->closed =~ /^Y/i;
@@
-169,7
+172,7
@@
sub delete {
if ( $conf->config('deletecredits') ne '' ) {
if ( $conf->config('deletecredits') ne '' ) {
- my $cust_main =
qsearchs('cust_main',{ 'custnum' => $self->custnum })
;
+ my $cust_main =
$self->cust_main
;
my $error = send_email(
'from' => $conf->config('invoice_from'), #??? well as good as any
my $error = send_email(
'from' => $conf->config('invoice_from'), #??? well as good as any
@@
-203,8
+206,7
@@
sub delete {
=item replace OLD_RECORD
=item replace OLD_RECORD
-Credits may not be modified; there would then be no record the credit was ever
-posted.
+You can, but probably shouldn't modify credits...
=cut
=cut
diff --git
a/FS/FS/cust_pay.pm
b/FS/FS/cust_pay.pm
index
f057d2f
..
bc5fbab
100644
(file)
--- a/
FS/FS/cust_pay.pm
+++ b/
FS/FS/cust_pay.pm
@@
-272,12
+272,14
@@
sub void {
=item delete
=item delete
-Deletes this payment and all associated applications (see L<FS::cust_bill_pay>),
-unless the closed flag is set. In most cases, you want to use the void
-method instead to leave a record of the deleted payment.
+Unless the closed flag is set, deletes this payment and all associated
+applications (see L<FS::cust_bill_pay> and L<FS::cust_pay_refund>). In most
+cases, you want to use the void method instead to leave a record of the
+deleted payment.
=cut
=cut
+# very similar to FS::cust_credit::delete
sub delete {
my $self = shift;
return "Can't delete closed payment" if $self->closed =~ /^Y/i;
sub delete {
my $self = shift;
return "Can't delete closed payment" if $self->closed =~ /^Y/i;
@@
-345,7
+347,16
@@
sub delete {
=item replace OLD_RECORD
=item replace OLD_RECORD
-You probably shouldn't modify payments...
+You can, but probably shouldn't modify payments...
+
+=cut
+
+sub replace {
+ #return "Can't modify payment!"
+ my $self = shift;
+ return "Can't modify closed payment" if $self->closed =~ /^Y/i;
+ $self->SUPER::replace(@_);
+}
=item check
=item check