fix radius attribute adding

diff --git a/FS/FS/svc_Common.pm b/FS/FS/svc_Common.pm
index c47cdbf..7e21646 100644 (file)
--- a/FS/FS/svc_Common.pm
+++ b/FS/FS/svc_Common.pm
@@ -195,15 +195,12 @@ sub cancel { ''; }
 
 =head1 VERSION
 
-$Id: svc_Common.pm,v 1.5 2001-09-06 20:41:59 ivan Exp $
+$Id: svc_Common.pm,v 1.6 2001-09-11 22:20:28 ivan Exp $
 
 =head1 BUGS
 
 The setfixed method return value.
 
-The new method should set defaults from part_svc (like the check method
-sets fixed values)?
-
 =head1 SEE ALSO
 
 L<FS::Record>, L<FS::cust_svc>, L<FS::part_svc>, L<FS::cust_pkg>, schema.html

diff --git a/bin/fs-radius-add-check b/bin/fs-radius-add-check
index eedd9b6..ca0492f 100755 (executable)
--- a/bin/fs-radius-add-check
+++ b/bin/fs-radius-add-check
@@ -10,7 +10,7 @@ use FS::raddb;
 die "Not running uid freeside!" unless checkeuid();
 
 my %attrib2db =
-  map { $FS::raddb::attrib{lc($_)} => $_ } keys %FS::raddb::attrib;
+  map { lc($FS::raddb::attrib{$_}) => $_ } keys %FS::raddb::attrib;
 
 my $user = shift or die &usage;
 getsecrets($user);
@@ -39,14 +39,16 @@ my($char_d) = 80; #default maxlength for text fields
 ###
 
 foreach my $attribute ( @attributes ) {
-  foreach my $statement ( 
-    "ALTER TABLE svc_acct ADD rc_$attribute varchar($char_d) NULL",
-#    "ALTER TABLE part_svc ADD svc_acct__rc_$attribute varchar($char_d) NULL;",
-#    "ALTER TABLE part_svc ADD svc_acct__rc_${attribute}_flag char(1) NULL;",
-  ) {
-    $dbh->do( $statement ) or warn "Error executing $statement: ". $dbh->errstr;  }
+  my $statement =
+    "ALTER TABLE svc_acct ADD COLUMN rc_$attribute varchar($char_d) NULL";
+  my $sth = $dbh->prepare( $statement )
+   or warn "Error preparing $statement: ". $dbh->errstr;
+  my $rc = $sth->execute
+    or warn "Error executing $statement: ". $sth->errstr;
 }
 
+$dbh->commit or die $dbh->errstr;
+
 $dbh->disconnect or die $dbh->errstr;
 
 print "\n\n", "Now you must run dbdef-create.\n\n";
@@ -55,4 +57,3 @@ sub usage {
   die "Usage:\n  fs-radius-add user\n"; 
 }
 
-

diff --git a/bin/fs-radius-add-reply b/bin/fs-radius-add-reply
index d2f2e11..2f38fbc 100755 (executable)
--- a/bin/fs-radius-add-reply
+++ b/bin/fs-radius-add-reply
@@ -10,7 +10,7 @@ use FS::raddb;
 die "Not running uid freeside!" unless checkeuid();
 
 my %attrib2db =
-  map { $FS::raddb::attrib{lc($_)} => $_ } keys %FS::raddb::attrib;
+  map { lc($FS::raddb::attrib{$_}) => $_ } keys %FS::raddb::attrib;
 
 my $user = shift or die &usage;
 getsecrets($user);
@@ -39,14 +39,16 @@ my($char_d) = 80; #default maxlength for text fields
 ###
 
 foreach my $attribute ( @attributes ) {
-  foreach my $statement ( 
-    "ALTER TABLE svc_acct ADD radius_$attribute varchar($char_d) NULL",
-#    "ALTER TABLE part_svc ADD svc_acct__radius_$attribute varchar($char_d) NULL;",
-#    "ALTER TABLE part_svc ADD svc_acct__radius_${attribute}_flag char(1) NULL;",
-  ) {
-    $dbh->do( $statement ) or warn "Error executing $statement: ". $dbh->errstr;  }
+  my $statement =
+    "ALTER TABLE svc_acct ADD COLUMN radius_$attribute varchar($char_d) NULL";
+  my $sth = $dbh->prepare( $statement )
+    or warn "Error preparing $statement: ". $dbh->errstr;
+  $sth->execute
+    or warn "Error executing $statement: ". $sth->errstr;
 }
 
+$dbh->commit or die $dbh->errstr;
+
 $dbh->disconnect or die $dbh->errstr;
 
 print "\n\n", "Now you must run dbdef-create.\n\n";

diff --git a/bin/fs-setup b/bin/fs-setup
index 9534eb2..e7dda8e 100755 (executable)
--- a/bin/fs-setup
+++ b/bin/fs-setup
@@ -1,6 +1,6 @@
 #!/usr/bin/perl -Tw
 #
-# $Id: fs-setup,v 1.57 2001-09-11 00:07:30 ivan Exp $
+# $Id: fs-setup,v 1.58 2001-09-11 22:20:28 ivan Exp $
 
 #to delay loading dbdef until we're ready
 BEGIN { $FS::Record::setup_hack = 1; }
@@ -20,7 +20,7 @@ use FS::raddb;
 die "Not running uid freeside!" unless checkeuid();
 
 my %attrib2db =
-  map { $FS::raddb::attrib{lc($_)} => $_ } keys %FS::raddb::attrib;
+  map { lc($FS::raddb::attrib{$_}) => $_ } keys %FS::raddb::attrib;
 
 my $user = shift or die &usage;
 getsecrets($user);

diff --git a/bin/svc_acct.export b/bin/svc_acct.export
index a5ec45d..3b8853b 100755 (executable)
--- a/bin/svc_acct.export
+++ b/bin/svc_acct.export
@@ -1,6 +1,6 @@
 #!/usr/bin/perl -w
 #
-# $Id: svc_acct.export,v 1.23 2001-08-17 10:57:40 ivan Exp $
+# $Id: svc_acct.export,v 1.24 2001-09-11 22:20:28 ivan Exp $
 #
 # Create and export password, radius and vpopmail password files:
 # passwd, passwd.adjunct, shadow, acp_passwd, acp_userinfo, acp_dialup
@@ -56,7 +56,7 @@ my $icradius_mysqlsource =
 my $icradius_dbh;
 if ( $icradiusmachines && $conf->exists('icradius_secrets') ) {
   $icradius_dbh = DBI->connect($conf->config('icradius_secrets'))
-    or die $DBI::errstr;;
+    or die $DBI::errstr;
 } else {
   $icradius_dbh = dbh;
 }