avoid uninitialized value errors

diff --git a/FS/FS/svc_Common.pm b/FS/FS/svc_Common.pm
index d5083fd..962e36a 100644 (file)
--- a/FS/FS/svc_Common.pm
+++ b/FS/FS/svc_Common.pm
@@ -51,8 +51,8 @@ sub new {
   $self->{'Hash'} = { map { $_ => $newhash->{$_} } qw(svcnum svcpart) };
   $self->setdefault;
   $self->{'Hash'}{$_} = $newhash->{$_}
-    foreach grep length($newhash->{$_}),
-            keys %$newhash;
+    foreach grep { defined($newhash->{$_}) && length($newhash->{$_}) }
+                 keys %$newhash;
 
   foreach my $field ( grep !defined($self->{'Hash'}{$_}), $self->fields ) { 
     $self->{'Hash'}{$field}='';