projects
/
freeside.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
baf358b
)
add unchecked vs. ok distinction to lint
author
ivan
<ivan>
Tue, 26 Aug 2008 23:53:47 +0000
(23:53 +0000)
committer
ivan
<ivan>
Tue, 26 Aug 2008 23:53:47 +0000
(23:53 +0000)
FS/FS/Tron.pm
patch
|
blob
|
history
httemplate/elements/mcp_lint.html
patch
|
blob
|
history
diff --git
a/FS/FS/Tron.pm
b/FS/FS/Tron.pm
index
3328095
..
dcb917e
100644
(file)
--- a/
FS/FS/Tron.pm
+++ b/
FS/FS/Tron.pm
@@
-53,6
+53,7
@@
sub tron_scan {
$hash{$option} = $value;
}
close READER;
$hash{$option} = $value;
}
close READER;
+ close WRITER;
unless ( keys %hash ) {
return "error scanning $machine\n";
unless ( keys %hash ) {
return "error scanning $machine\n";
@@
-86,6
+87,8
@@
sub tron_lint {
push @lint, "$option is $current" unless $current =~ $desired{$option};
}
push @lint, "$option is $current" unless $current =~ $desired{$option};
}
+ push @lint, 'unchecked' unless scalar($cust_svc->options);
+
@lint;
}
@lint;
}
diff --git
a/httemplate/elements/mcp_lint.html
b/httemplate/elements/mcp_lint.html
index
826549c
..
9e2b5ca
100644
(file)
--- a/
httemplate/elements/mcp_lint.html
+++ b/
httemplate/elements/mcp_lint.html
@@
-1,5
+1,6
@@
% foreach my $lint (@lint) {
% foreach my $lint (@lint) {
- <FONT COLOR="#FF0000"><% $lint %></FONT><BR>
+% my $color = ( $lint =~ /unchecked$/ ? '#FF9900' : '#FF0000' );
+ <FONT COLOR="<% $color %>"><% $lint %></FONT><BR>
% }
<%init>
% }
<%init>