projects
/
freeside.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
45121e0
)
avoid sending SureTax requests when no items are taxable
author
Mark Wells
<mark@freeside.biz>
Fri, 10 Jul 2015 21:29:33 +0000
(14:29 -0700)
committer
Mark Wells
<mark@freeside.biz>
Fri, 10 Jul 2015 21:29:33 +0000
(14:29 -0700)
FS/FS/TaxEngine/suretax.pm
patch
|
blob
|
history
diff --git
a/FS/FS/TaxEngine/suretax.pm
b/FS/FS/TaxEngine/suretax.pm
index
8139b1d
..
4e7edd5
100644
(file)
--- a/
FS/FS/TaxEngine/suretax.pm
+++ b/
FS/FS/TaxEngine/suretax.pm
@@
-85,6
+85,8
@@
sub build_request {
my @lines = map { $self->build_item($_) }
$cust_bill->cust_bill_pkg;
my @lines = map { $self->build_item($_) }
$cust_bill->cust_bill_pkg;
+ return if !@lines;
+
my $ClientNumber = $conf->config('suretax-client_number')
or die "suretax-client_number config required.\n";
my $ValidationKey = $conf->config('suretax-validation_key')
my $ClientNumber = $conf->config('suretax-client_number')
or die "suretax-client_number config required.\n";
my $ValidationKey = $conf->config('suretax-validation_key')
@@
-306,6
+308,10
@@
sub make_taxlines {
# assemble the request hash
my $request = $self->build_request;
# assemble the request hash
my $request = $self->build_request;
+ if (!$request) {
+ warn "no taxable items in invoice; skipping SureTax request\n" if $DEBUG;
+ return;
+ }
warn "sending SureTax request\n" if $DEBUG;
my $request_json = $json->encode($request);
warn "sending SureTax request\n" if $DEBUG;
my $request_json = $json->encode($request);