import rt 3.8.9

[freeside.git] / rt / html / REST / 1.0 / Forms / ticket / history

diff --git a/rt/html/REST/1.0/Forms/ticket/history b/rt/html/REST/1.0/Forms/ticket/history
index f60615a..b5ae187 100644 (file)
--- a/rt/html/REST/1.0/Forms/ticket/history
+++ b/rt/html/REST/1.0/Forms/ticket/history
@@ -1,8 +1,8 @@
-%# {{{ BEGIN BPS TAGGED BLOCK
+%# BEGIN BPS TAGGED BLOCK {{{
 %# 
 %# COPYRIGHT:
 %#  
-%# This software is Copyright (c) 1996-2004 Best Practical Solutions, LLC 
+%# This software is Copyright (c) 1996-2009 Best Practical Solutions, LLC 
 %#                                          <jesse@bestpractical.com>
 %# 
 %# (Except where explicitly superseded by other copyright notices)
@@ -22,7 +22,9 @@
 %# 
 %# You should have received a copy of the GNU General Public License
 %# along with this program; if not, write to the Free Software
-%# Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+%# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+%# 02110-1301 or visit their web page on the internet at
+%# http://www.gnu.org/licenses/old-licenses/gpl-2.0.html.
 %# 
 %# 
 %# CONTRIBUTION SUBMISSION POLICY:
@@ -42,7 +44,7 @@
 %# works based on those contributions, and sublicense and distribute
 %# those contributions and any derivatives thereof.
 %# 
-%# }}} END BPS TAGGED BLOCK
+%# END BPS TAGGED BLOCK }}}
 %# REST/1.0/Forms/ticket/history
 %#
 <%ARGS>
@@ -51,7 +53,7 @@ $args => undef
 $format => undef
 $fields => undef
 </%ARGS>
-<%perl>
+<%INIT>
 my $ticket = new RT::Ticket $session{CurrentUser};
 my ($c, $o, $k, $e) = ("", [], {}, "");
 
@@ -94,11 +96,21 @@ if ($type) {
 if ($tid) {
     my @data;
     my $t = new RT::Transaction $session{CurrentUser};
-    $t->Load($tid);
+    
+    # this paragraph limits the transaction ID query to transactions on this ticket. 
+    # Otherwise you can query any transaction from any ticket, which makes no sense.
+    my $Transactions = $ticket->Transactions;
+    my $tok=0;
+    while (my $T = $Transactions->Next()) {
+       $tok=1 if ($T->Id == $tid)
+    }
+    if ($tok) {
+       $t->Load($tid);
+    } else {
+       return [ "# Transaction $tid is not related to Ticket $id", [], {}, 1 ];
+    }
 
     push @data, [ id    => $t->Id   ];
-    push @data, [ EffectiveTicket    => $t->EffectiveTicket   ]
-       if (!%$fields || exists $fields->{lc 'EffectiveTicket'});
     push @data, [ Ticket    => $t->Ticket   ]
        if (!%$fields || exists $fields->{lc 'Ticket'});
     push @data, [ TimeTaken    => $t->TimeTaken   ]
@@ -170,8 +182,7 @@ if ($tid) {
            $fieldstring .= $key;
        }
        my ($content, $forms);
-
-       $m->subexec("$RT::WebPath/REST/1.0/show", 
+       $m->subexec("/REST/1.0/show", 
                    id => \@tid, 
                    format => $format,
                     fields => $fieldstring);
@@ -186,4 +197,4 @@ if (!$c) {
 
 return [ $c, $o, $k, $e ];
 
-</%perl>
+</%INIT>