Merge branch 'patch-1' of https://github.com/gjones2/Freeside

[freeside.git] / httemplate / edit / process / cust_credit.cgi

diff --git a/httemplate/edit/process/cust_credit.cgi b/httemplate/edit/process/cust_credit.cgi
index 8715ad6..245f31a 100755 (executable)
--- a/httemplate/edit/process/cust_credit.cgi
+++ b/httemplate/edit/process/cust_credit.cgi
@@ -12,11 +12,10 @@
 %      or die "unknown custnum $custnum";
 %    $cust_main->apply_credits;
 %  }
-%  #print $cgi->redirect(popurl(3). "view/cust_main.cgi?$custnum");
 %
 %  $dbh->commit or die $dbh->errstr if $oldAutoCommit;
 %  
-<% header('Credit sucessful') %>
+<% header(emt('Credit successful')) %>
   <SCRIPT TYPE="text/javascript">
     window.top.location.reload();
   </SCRIPT>
@@ -28,7 +27,7 @@
 die "access denied"
   unless $FS::CurrentUser::CurrentUser->access_right('Post credit');
 
-$cgi->param('custnum') =~ /^(\d*)$/ or die "Illegal custnum!";
+$cgi->param('custnum') =~ /^(\d+)$/ or die "Illegal custnum!";
 my $custnum = $1;
 
 $cgi->param('reasonnum') =~ /^(-?\d+)$/ or die "Illegal reasonnum";
@@ -43,9 +42,10 @@ if ($reasonnum == -1) {
 
   $error = 'Enter a new reason (or select an existing one)'
     unless $cgi->param('newreasonnum') !~ /^\s*$/;
-  my $reason = new FS::reason({ 'reason_type' => $cgi->param('newreasonnumT'),
-                                'reason'      => $cgi->param('newreasonnum'),
-                              });
+  my $reason = new FS::reason {
+                 'reason_type' => scalar($cgi->param('newreasonnumT')),
+                 'reason'      => scalar($cgi->param('newreasonnum')),
+               };
   $error ||= $reason->insert;
   $cgi->param('reasonnum', $reason->reasonnum)
     unless $error;