fix cancellation errors with updated flat_introrate, RT#5865
[freeside.git] / FS / FS / part_pkg / flat_delayed.pm
index 8ac1682..33f9dd8 100644 (file)
@@ -10,6 +10,7 @@ use FS::part_pkg::flat;
 %info = (
   'name' => 'Free (or setup fee) for X days, then flat rate'.
             ' (anniversary billing)',
+  'shortname' => 'Anniversary, with intro period',
   'fields' =>  {
     'setup_fee' => { 'name' => 'Setup fee for this package',
                      'default' => 0,
@@ -21,8 +22,8 @@ use FS::part_pkg::flat;
                      'default' => 0,
                     },
     'recur_notify' => { 'name' => 'Number of days before recurring billing'.
-                                  'commences to notify customer. (0 means '.
-                                  'no warning)',
+                                  ' commences to notify customer. (0 means'.
+                                  ' no warning)',
                      'default' => 0,
                     },
     'unused_credit' => { 'name' => 'Credit the customer for the unused portion'.
@@ -35,7 +36,7 @@ use FS::part_pkg::flat;
                   ],
   #'setup' => '\'my $d = $cust_pkg->bill || $time; $d += 86400 * \' + what.free_days.value + \'; $cust_pkg->bill($d); $cust_pkg_mod_flag=1; \' + what.setup_fee.value',
   #'recur' => 'what.recur_fee.value',
-  'weight' => 50,
+  'weight' => 12,
 );
 
 sub calc_setup {
@@ -57,7 +58,7 @@ sub calc_remain {
   return 0 if    $last_bill + (86400 * $free_days) == $next_bill
               && $last_bill == $cust_pkg->setup;
 
-  return 0 if    ! $self->base_recur
+  return 0 if    ! $self->base_recur($cust_pkg)
               || ! $self->option('unused_credit', 1)
               || ! $last_bill
               || ! $next_bill;