RT# 78547 noexport_hack part_svc::netsapiens

[freeside.git] / FS / FS / part_export / netsapiens.pm

diff --git a/FS/FS/part_export/netsapiens.pm b/FS/FS/part_export/netsapiens.pm
index 867c19a..c6110f5 100644 (file)
--- a/FS/FS/part_export/netsapiens.pm
+++ b/FS/FS/part_export/netsapiens.pm
@@ -1,12 +1,14 @@
 package FS::part_export::netsapiens;
+use base qw( FS::part_export );
 
-use vars qw(@ISA $me %info);
+use vars qw( $me %info );
 use MIME::Base64;
 use Tie::IxHash;
-use FS::part_export;
 use Date::Format qw( time2str );
+use Regexp::Common qw( URI );
+use REST::Client;
+use Carp qw(carp);
 
-@ISA = qw(FS::part_export);
 $me = '[FS::part_export::netsapiens]';
 
 #These export options set default values for the various commands
@@ -42,6 +44,11 @@ my %features = (
   'sim' => 'Simultaneous Ring',
 );
 
+my %feature_param = (
+  'dnd' => 'n/a',
+  'sim' => '$phonenum',
+);
+
 tie my %options, 'Tie::IxHash',
   'login'           => { label=>'NetSapiens tac2 User API username' },
   'password'        => { label=>'NetSapiens tac2 User API password' },
@@ -66,13 +73,11 @@ tie my %options, 'Tie::IxHash',
 ;
 
 %info = (
-  'svc'      => [ 'svc_phone', ], # 'part_device',
-  'desc'     => 'Provision phone numbers to NetSapiens',
-  'options'  => \%options,
-  'notes'    => <<'END'
-Requires installation of
-<a href="http://search.cpan.org/dist/REST-Client">REST::Client</a>
-from CPAN.
+  'svc'        => [qw( svc_phone part_device )],
+  'desc'       => 'Provision phone numbers to NetSapiens',
+  'options'    => \%options,
+  'no_machine' => 1,
+  'notes'      => <<'END'
 END
 );
 
@@ -80,6 +85,22 @@ END
 
 sub rebless { shift; }
 
+
+sub check_options {
+  my ($self, $options) = @_;
+       
+  my $rex = qr/$RE{URI}{HTTP}{-scheme => qr|https?|}/;                 # match any "http:" or "https:" URL
+       
+  for my $key (qw/url device_url/) {
+    if ($$options{$key} && ($$options{$key} !~ $rex)) {
+      return "Invalid (URL): " . $$options{$key};
+    }
+  }
+  return '';
+}
+
+
+
 sub ns_command {
   my $self = shift;
   $self->_ns_command('', @_);
@@ -95,8 +116,6 @@ sub _ns_command {
 
   # kludge to curb excessive paranoia in LWP 6.0+
   local $ENV{'PERL_LWP_SSL_VERIFY_HOSTNAME'} = 0;
-  eval 'use REST::Client';
-  die $@ if $@;
 
   my $ns = new REST::Client 'host'=>$self->option($prefix.'url');
 
@@ -245,11 +264,14 @@ sub ns_create_or_update {
   ###
   foreach $feature (split /\s+/, $self->option('features') ) {
 
+    my $param= exists($feature_param{$feature}) ? $feature_param{$feature} : '';
+    $param = $phonenum if $param eq '$phonenum';
+
     my $nsf = $self->ns_command( 'PUT', $self->ns_feature($svc_phone, $feature),
       'control'    => 'd', #User Control, disable
       'expires'    => 'never',
       #'ts'         => '', #?
-      #'parameters' => '',
+      'parameters' => $param,
       'hour_match' => '*',
       'time_frame' => '*',
       'activation' => 'now',
@@ -371,6 +393,12 @@ sub _export_unsuspend {
 sub export_device_insert {
   my( $self, $svc_phone, $phone_device ) = (shift, shift, shift);
 
+  if ( $FS::svc_Common::noexport_hack ) {
+    carp 'export_device_insert() suppressed by noexport_hack'
+      if $self->option('debug');
+    return;
+  }
+
   my $domain = $self->ns_domain($svc_phone);
   my $countrycode = $svc_phone->countrycode;
   my $phonenum    = $svc_phone->phonenum;
@@ -405,6 +433,12 @@ sub export_device_insert {
 sub export_device_delete {
   my( $self, $svc_phone, $phone_device ) = (shift, shift, shift);
 
+  if ( $FS::svc_Common::noexport_hack ) {
+    carp 'export_device_delete() suppressed by noexport_hack'
+      if $self->option('debug');
+    return;
+  }
+
   my $ns = $self->ns_device_command(
     'DELETE', $self->ns_device($svc_phone, $phone_device),
   );