patch from Charles Shapiro <cshapiro@numethods.com> to fix column ordering

when reading from Pg databases

diff --git a/Changes b/Changes
index 99bc7b6..dbb86b3 100644 (file)
--- a/Changes
+++ b/Changes
@@ -1,5 +1,10 @@
 Revision history for Perl extension DBIx::DBSchema.
 
+0.18 unreleased
+       - Added Table::delcolumn
+       - patch from Charles Shapiro <cshapiro@numethods.com> to add
+          `ORDER BY a.attnum' to the SQL in DBIx::DBSchema::DBD::Pg::columns
+
 0.17  Sat Jul  7 17:55:33 2001
        - Rework Table->new interface for named params
        - Fixes for Pg blobs, yay!

diff --git a/DBSchema/DBD/Pg.pm b/DBSchema/DBD/Pg.pm
index ad1613d..76bcf2d 100644 (file)
--- a/DBSchema/DBD/Pg.pm
+++ b/DBSchema/DBD/Pg.pm
@@ -4,7 +4,7 @@ use strict;
 use vars qw($VERSION @ISA %typemap);
 use DBIx::DBSchema::DBD;
 
-$VERSION = '0.02';
+$VERSION = '0.03';
 @ISA = qw(DBIx::DBSchema::DBD);
 
 %typemap = (
@@ -37,6 +37,7 @@ sub columns {
     FROM pg_class c, pg_attribute a, pg_type t
     WHERE c.relname = '$table'
       AND a.attnum > 0 AND a.attrelid = c.oid AND a.atttypid = t.oid
+    ORDER BY a.attnum
 END
   $sth->execute or die $sth->errstr;
   map {