push @after_add, sub {
my($table, $column) = @_;
- #needs more work for old Pg
+ #needs more work for old Pg?
+
+ my $pg_server_version = $dbh->{'pg_server_version'};
+ unless ( $pg_server_version =~ /\d/ ) {
+ warn "WARNING: no pg_server_version! Assuming >= 7.3\n";
+ $pg_server_version = 70300;
+ }
my $nextval;
- if ( $dbh->{'pg_server_version'} > 70300 ) {
+ if ( $pg_server_version >= 70300 ) {
$nextval = "nextval('public.${table}_${column}_seq'::text)";
} else {
$nextval = "nextval('${table}_${column}_seq'::text)";
$real_null = $self->null;
$self->null('NULL');
- #if ( $dbh->{'pg_server_version'} > 70300 ) { #this seemed to work on 7.3
- if ( $dbh->{'pg_server_version'} > 70400 ) { #after all...
+ my $pg_server_version = $dbh->{'pg_server_version'};
+ unless ( $pg_server_version =~ /\d/ ) {
+ warn "WARNING: no pg_server_version! Assuming >= 7.3\n";
+ $pg_server_version = 70300;
+ }
+
+ if ( $pg_server_version >= 70300 ) { #this did work on 7.3
+ #if ( $pg_server_version > 70400 ) {
push @after_add, sub {
my($table, $column) = @_;
# change nullability from NOT NULL to NULL
if ( ! $self->null && $new->null ) {
- if ( $driver eq 'Pg' && $dbh->{'pg_server_version'} < 70300 ) {
- push @r, "UPDATE pg_attribute SET attnotnull = FALSE
- WHERE attname = '$name'
- AND attrelid = ( SELECT oid FROM pg_class
- WHERE relname = '$table'
- )";
- } else {
- push @r, "ALTER TABLE $table ALTER COLUMN $name DROP NOT NULL";
+ my $alter = "ALTER TABLE $table ALTER COLUMN $name DROP NOT NULL";
+
+ if ( $driver eq 'Pg' ) {
+
+ my $pg_server_version = $dbh->{'pg_server_version'};
+ unless ( $pg_server_version =~ /\d/ ) {
+ warn "WARNING: no pg_server_version! Assuming >= 7.3\n";
+ $pg_server_version = 70300;
+ }
+
+ if ( $pg_server_version < 70300 ) {
+ $alter = "UPDATE pg_attribute SET attnotnull = FALSE
+ WHERE attname = '$name'
+ AND attrelid = ( SELECT oid FROM pg_class
+ WHERE relname = '$table'
+ )";
+ }
+
}
+
+ push @r, $alter;
+
}
# change nullability from NULL to NOT NULL...
# the table first...
if ( $self->null && ! $new->null ) {
- if ( $driver eq 'Pg' && $dbh->{'pg_server_version'} < 70300 ) {
- push @r, "UPDATE pg_attribute SET attnotnull = TRUE
- WHERE attname = '$name'
- AND attrelid = ( SELECT oid FROM pg_class
- WHERE relname = '$table'
- )";
- } else {
- push @r, "ALTER TABLE $table ALTER COLUMN $name SET NOT NULL";
+ my $alter = "ALTER TABLE $table ALTER COLUMN $name SET NOT NULL";
+
+ if ( $driver eq 'Pg' ) {
+
+ my $pg_server_version = $dbh->{'pg_server_version'};
+ unless ( $pg_server_version =~ /\d/ ) {
+ warn "WARNING: no pg_server_version! Assuming >= 7.3\n";
+ $pg_server_version = 70300;
+ }
+
+ if ( $pg_server_version < 70300 ) {
+ push @r, "UPDATE pg_attribute SET attnotnull = TRUE
+ WHERE attname = '$name'
+ AND attrelid = ( SELECT oid FROM pg_class
+ WHERE relname = '$table'
+ )";
+ }
+
}
+
+ push @r, $alter;
+
}
# change other stuff...