documentation and other minor fixes

diff --git a/VirtualNet.pm b/VirtualNet.pm
index 84530b6..81671c0 100644 (file)
--- a/VirtualNet.pm
+++ b/VirtualNet.pm
@@ -128,7 +128,7 @@ sub submit {
     }
 
     if ( $page =~ /^(\d+)\s+\-\s+(\S.*)$/ ) {
-      die "protocol unsucessful: $page";
+      die "VirtualNet protocol error: $page";
       #$self->is_success(0);
       #$self->result_code($1);
       #$self->error_message($2);
@@ -167,19 +167,6 @@ sub submit {
 
     }
 
-#    my( $r, $a, $m, $s, $e ) =
-#      map { /^\s*\w+\s*\=\s*(.*)$/; $1; } split("\n", $page);
-
-#    if ( $m =~ /^200/ ) {
-#      $self->is_success(1);
-#      $self->result_code($e);
-#      $self->authorization($a);
-#    } else {
-#      $self->is_success(0);
-#      $self->result_code($e);
-#      $self->error_message($m);
-#    }
-
 }
 
 sub testhost {
@@ -210,7 +197,7 @@ sub testhost {
   #warn "Response: $page";
 
   if ( $page =~ /^(\d+)\s+\-\s+(\S.*)$/ ) {
-    die "protocol unsucessful: $page";
+    die "VirtualNet protocol error: $page";
     #$self->is_success(0);
     #$self->result_code($1);
     #$self->error_message($2);
@@ -297,7 +284,7 @@ sub eis1080_request {
   $content .= $FS;
 
   # - 0-29 Address Verification Data
-#  $content .= substr($param->{address}, 0, 23)." ". substr($param->{zip}, 0, 5);
+  $content .= substr($param->{address}, 0, 23)." ". substr($param->{zip}, 0, 5);
 
   $content .= $FS; # - 1 Field Separator
   $content .= $FS; # - 1 Field Separator
@@ -555,18 +542,18 @@ sub eis1081_request {
   $detail .= '00'; # 82-83 2 NUM Transaction Status Code 00 4.208
   $detail .= '0'; # 84 1 A/N Reimbursement Attribute 0 4.157
 
-  # ICKKKKKKKK do this better
   my $amount = $param->{amount};
   $amount =~ s/\.//;
-  $amount = '000000000000'.$amount;
-  $amount =~ /^\d*(\d{12})$/;
-  $amount = $1;
+  $amount = substr('000000000000'.$amount,-12);
 
-  $detail .= $amount; # 85-96 12 NUM Settlement Amount Right-Justified/Zero-Filled 4.175
+  $detail .= $amount; # 85-96 12 NUM Settlement Amount
+                      # Right-Justified/Zero-Filled 4.175
 
-  $detail .= $amount; # 97-108 12 NUM Authorized Amount Right-Justified/Zero-Filled 4.14
+  $detail .= $amount; # 97-108 12 NUM Authorized Amount
+                      # Right-Justified/Zero-Filled 4.14
 
-  $detail .= $amount; # 109-120 12 NUM Total Authorized Amount Right-Justified/Zero-Filled 4.201
+  $detail .= $amount; # 109-120 12 NUM Total Authorized Amount
+                      # Right-Justified/Zero-Filled 4.201
 
 #  $detail .= '1'; # 121 1 A/N Purchase Identifier Format Code 1 4.150
 #
@@ -742,22 +729,19 @@ Business::OnlinePayment::VirtualNet - Vital VirtualNet backend for Business::Onl
       amount         => '49.95',
       invoice_number => '100100',
       name           => 'Tofu Beast',
-      card_number    => '4007000000027',
-      expiration     => '09/02',
+      card_number    => '4111111111111111',
+      expiration     => '09/03',
   );
   $tx->submit();
 
   if( $tx->is_success() ) {
-      print "Card processed successfully: ".$tx->authorization."\n";
+      print "Card authorized successfully: ".$tx->authorization."\n";
   } else {
-      print "Card was rejected: ".$tx->error_message."\n";
+      print "Error: ".$tx->error_message."\n";
   }
 
  if( $tx->is_success() ) {
 
-      $auth = $tx->authorization;
-      $ordernum = $tx->order_number;
-
       my $capture = new Business::OnlinePayment("VirtualNet",
         'agent'       => '000001',
         'chain'       => '000000', #optional?
@@ -771,6 +755,19 @@ Business::OnlinePayment::VirtualNet - Vital VirtualNet backend for Business::Onl
       );
 
       $capture->content(
+        type           => 'CC',
+        action         => 'Post Authorization',
+        amount         => '49.95',
+        card_number    => '4111111111111111',
+        expiration     => '09/03',
+        authorization             => $tx->authorization,
+        authorization_source_code => $tx->authorization_source_code,
+        returned_ACI              => $tx->returned_ACI,
+        transaction_identifier    => $tx->transaction_identifier,
+        validation_code           => $tx->validation_code,
+        transaction_sequence_num  => $tx->transaction_sequence_num,
+        #description    => 'Business::OnlinePayment::BankOfAmerica visa test',
+
           action         => 'Post Authorization',
       #    order_number   => $ordernum,
       #    amount         => '0.01',
@@ -781,9 +778,9 @@ Business::OnlinePayment::VirtualNet - Vital VirtualNet backend for Business::Onl
       $capture->submit();
 
       if( $capture->is_success() ) { 
-          print "Card captured successfully: ".$capture->authorization."\n";
+          print "Card captured successfully\n";
       } else {
-          print "Card was rejected: ".$capture->error_message."\n";
+          print "Error: ".$capture->error_message."\n";
       }
 
   }

diff --git a/t/bad_auth.t b/t/bad_auth.t
index aa10d3c..9dbde52 100644 (file)
--- a/t/bad_auth.t
+++ b/t/bad_auth.t
@@ -39,10 +39,10 @@ $tx->content(
     customer_id    => 'jsk',
     first_name     => 'Tofu',
     last_name      => 'Beast',
-    address        => '123 Anystreet',
+    address        => '8320 Anystreet',
     city           => 'Anywhere',
     state          => 'UT',
-    zip            => '84058',
+    zip            => '85284',
     card_number    => '4111111111111111',
     expiration     => '09/03',
 );

diff --git a/t/credit_card.t b/t/credit_card.t
index 8e2777a..84e729c 100644 (file)
--- a/t/credit_card.t
+++ b/t/credit_card.t
@@ -64,16 +64,15 @@ if($tx->is_success()) {
 $tx->content(
   type           => 'CC',
   action         => 'Post Authorization',
-  #order_number   => $ordernum,
-  amount         => '10.00',
+  amount         => '999910.00',
   card_number    => '4111111111111111',
   expiration     => '09/03',
-  authorization  => $tx->authorization,
+  authorization             => $tx->authorization,
   authorization_source_code => $tx->authorization_source_code,
-  returned_ACI => $tx->returned_ACI,
-  transaction_identifier => $tx->transaction_identifier,
-  validation_code => $tx->validation_code,
-  transaction_sequence_num => $tx->transaction_sequence_num,
+  returned_ACI              => $tx->returned_ACI,
+  transaction_identifier    => $tx->transaction_identifier,
+  validation_code           => $tx->validation_code,
+  transaction_sequence_num  => $tx->transaction_sequence_num,
   #description    => 'Business::OnlinePayment::BankOfAmerica visa test',
 );