should avoid spurious uninitialized value warnings on upgrade
authorivan <ivan>
Wed, 9 Jul 2008 20:37:20 +0000 (20:37 +0000)
committerivan <ivan>
Wed, 9 Jul 2008 20:37:20 +0000 (20:37 +0000)
FS/FS/part_pkg.pm

index 7acada5..6ff1fbb 100644 (file)
@@ -376,7 +376,12 @@ sub replace {
   my $pkg_svc = $options{'pkg_svc'} || {};
   foreach my $part_svc ( qsearch('part_svc', {} ) ) {
     my $quantity = $pkg_svc->{$part_svc->svcpart} || 0;
-    my $primary_svc = $options{'primary_svc'} == $part_svc->svcpart ? 'Y' : '';
+    my $primary_svc =
+      ( defined($options{'primary_svc'})
+        && $options{'primary_svc'} == $part_svc->svcpart
+      )
+        ? 'Y'
+        : '';
 
     my $old_pkg_svc = qsearchs('pkg_svc', {
       'pkgpart' => $old->pkgpart,