#
# COPYRIGHT:
#
-# This software is Copyright (c) 1996-2011 Best Practical Solutions, LLC
+# This software is Copyright (c) 1996-2019 Best Practical Solutions, LLC
# <sales@bestpractical.com>
#
# (Except where explicitly superseded by other copyright notices)
my %plugins = RT::Shredder::Plugin->List;
# load plugin by name
- my $plugin = new RT::Shredder::Plugin;
+ my $plugin = RT::Shredder::Plugin->new;
my( $status, $msg ) = $plugin->LoadByName( 'Tickets' );
unless( $status ) {
print STDERR "Couldn't load plugin 'Tickets': $msg\n";
}
# load plugin by preformatted string
- my $plugin = new RT::Shredder::Plugin;
+ my $plugin = RT::Shredder::Plugin->new;
my( $status, $msg ) = $plugin->LoadByString( 'Tickets=status,deleted' );
unless( $status ) {
print STDERR "Couldn't load plugin: $msg\n";
my $self = shift;
my %args = ( @_ );
$self->{'opt'} = \%args;
+ return;
}
=head2 List
my %res;
for my $f (reverse @files) {
- $res{$1} = $_ if $f =~ /([^\\\/]+)\.pm$/;
+ $res{$1} = $f if $f =~ /([^\\\/]+)\.pm$/;
}
return %res unless $type;
delete $res{'Base'};
foreach my $name( keys %res ) {
my $class = join '::', qw(RT Shredder Plugin), $name;
- unless( eval "require $class" ) {
+ unless( $class->require ) {
delete $res{ $name };
next;
}
Returns C<$status> and C<$message>. On errors status
is C<false> value.
+In scalar context, returns $status only.
+
=cut
sub LoadByName
{
my $self = shift;
my $name = shift or return (0, "Name not specified");
+ $name =~ /^\w+(::\w+)*$/ or return (0, "Invalid plugin name");
- local $@;
my $plugin = "RT::Shredder::Plugin::$name";
- eval "require $plugin" or return( 0, $@ );
- return( 0, "Plugin '$plugin' has no method new") unless $plugin->can('new');
+ $plugin->require or return( 0, "Failed to load $plugin" );
+ return wantarray ? ( 0, "Plugin '$plugin' has no method new") : 0 unless $plugin->can('new');
my $obj = eval { $plugin->new( @_ ) };
- return( 0, $@ ) if $@;
- return( 0, 'constructor returned empty object' ) unless $obj;
+ return wantarray ? ( 0, $@ ) : 0 if $@;
+ return wantarray ? ( 0, 'constructor returned empty object' ) : 0 unless $obj;
$self->Rebless( $obj );
- return( 1, "successfuly load plugin" );
+ return wantarray ? ( 1, "successfuly load plugin" ) : 1;
}
=head2 LoadByString