add repo info to doco yoyo

[Business-OnlinePayment.git] / OnlinePayment / HTTPS.pm

diff --git a/OnlinePayment/HTTPS.pm b/OnlinePayment/HTTPS.pm
index 1a86a1b..cb51905 100644 (file)
--- a/OnlinePayment/HTTPS.pm
+++ b/OnlinePayment/HTTPS.pm
@@ -6,8 +6,7 @@ use URI::Escape;
 use Tie::IxHash;
 use base qw(Business::OnlinePayment);
 
-$VERSION = '0.05_01';
-$VERSION = eval $VERSION;    # modperlstyle: convert the string into a number
+$VERSION = '0.09';
 $DEBUG   = 0;
 
 BEGIN {
@@ -86,8 +85,8 @@ In the latter case, ordering is preserved (see L<Tie::IxHash> to do so
 when passing a hashref).
 
 Returns a list consisting of the page content as a string, the HTTP
-response code, and a list of key/value pairs representing the HTTP
-response headers.
+response code and message (i.e. "200 OK" or "404 Not Found"), and a list of
+key/value pairs representing the HTTP response headers.
 
 The options hashref supports setting headers and Content-Type:
 
@@ -140,14 +139,31 @@ sub https_get {
               keys %$post_data );
     }
 
+    $self->build_subs(qw( response_page response_code response_headers ));
+
     if ( $ssl_module eq 'Net::SSLeay' ) {
 
         import Net::SSLeay qw(get_https make_headers);
         my $headers = make_headers(%headers);
-        get_https( $self->server, $self->port, $path, $headers, "",
-            $opts->{"Content-Type"} );
-    }
-    elsif ( $ssl_module eq 'Crypt::SSLeay' ) {
+
+        my( $res_page, $res_code, @res_headers ) =
+          get_https( $self->server,
+                     $self->port,
+                     $path,
+                     $headers,
+                     "",
+                     $opts->{"Content-Type"},
+                   );
+
+        $res_code =~ /^(HTTP\S+ )?(.*)/ and $res_code = $2;
+
+        $self->response_page( $res_page );
+        $self->response_code( $res_code );
+        $self->response_headers( { @res_headers } );
+
+        ( $res_page, $res_code, @res_headers );
+
+    } elsif ( $ssl_module eq 'Crypt::SSLeay' ) {
 
         import HTTP::Request::Common qw(GET);
 
@@ -156,17 +172,25 @@ sub https_get {
           unless $self->port == 443;
         $url .= "/$path";
 
-        my $ua  = new LWP::UserAgent;
+        my $ua = new LWP::UserAgent;
+        foreach my $hdr ( keys %headers ) {
+            $ua->default_header( $hdr => $headers{$hdr} );
+        }
         my $res = $ua->request( GET($url) );
 
-        (
-            $res->content, $res->code,
-            map { $_ => $res->header($_) } $res->header_field_names
-        );
-    }
-    else {
+        my @res_headers = map { $_ => $res->header($_) }
+                              $res->header_field_names;
+
+        $self->response_page( $res->content );
+        $self->response_code( $res->code. ' '. $res->message );
+        $self->response_headers( { @res_headers } );
+
+        ( $res->content, $res->code. ' '. $res->message, @res_headers );
+
+    } else {
         die "unknown SSL module $ssl_module";
     }
+
 }
 
 =item https_post [ \%options ] SCALAR | HASHREF | FIELD => VALUE, ...
@@ -178,8 +202,8 @@ passing a hashref).
 Also accepts instead a simple scalar containing the raw content.
 
 Returns a list consisting of the page content as a string, the HTTP
-response code, and a list of key/value pairs representing the HTTP
-response headers.
+response code and message (i.e. "200 OK" or "404 Not Found"), and a list of
+key/value pairs representing the HTTP response headers.
 
 The options hashref supports setting headers and Content-Type:
 
@@ -230,6 +254,8 @@ sub https_post {
             map { "  $_ => " . $post_data->{$_} . "\n" } keys %$post_data );
     }
 
+    $self->build_subs(qw( response_page response_code response_headers ));
+
     if ( $ssl_module eq 'Net::SSLeay' ) {
 
         import Net::SSLeay qw(post_https make_headers make_form);
@@ -242,10 +268,25 @@ sub https_post {
         }
 
         my $raw_data = ref($post_data) ? make_form(%$post_data) : $post_data;
-        post_https( $self->server, $self->port, $self->path, $headers,
-            $raw_data, $opts->{"Content-Type"} );
-    }
-    elsif ( $ssl_module eq 'Crypt::SSLeay' ) {
+
+        my( $res_page, $res_code, @res_headers ) =
+          post_https( $self->server,
+                      $self->port,
+                      $self->path,
+                      $headers,
+                      $raw_data,
+                      $opts->{"Content-Type"},
+                    );
+
+        $res_code =~ /^(HTTP\S+ )?(.*)/ and $res_code = $2;
+
+        $self->response_page( $res_page );
+        $self->response_code( $res_code );
+        $self->response_headers( { @res_headers } );
+
+        ( $res_page, $res_code, @res_headers );
+
+    } elsif ( $ssl_module eq 'Crypt::SSLeay' ) {
 
         import HTTP::Request::Common qw(POST);
 
@@ -259,6 +300,9 @@ sub https_post {
         }
 
         my $ua = new LWP::UserAgent;
+        foreach my $hdr ( keys %headers ) {
+            $ua->default_header( $hdr => $headers{$hdr} );
+        }
 
         my $res;
         if ( ref($post_data) ) {
@@ -271,14 +315,19 @@ sub https_post {
             $res = $ua->request($req);
         }
 
-        (
-            $res->content, $res->code,
-            map { $_ => $res->header($_) } $res->header_field_names
-        );
-    }
-    else {
+        my @res_headers = map { $_ => $res->header($_) }
+                              $res->header_field_names;
+
+        $self->response_page( $res->content );
+        $self->response_code( $res->code. ' '. $res->message );
+        $self->response_headers( { @res_headers } );
+
+        ( $res->content, $res->code. ' '. $res->message, @res_headers );
+
+    } else {
         die "unknown SSL module $ssl_module";
     }
+
 }
 
 =back