my @label = ();
if (my $type = $self->hardware_type) {
my $typenum_label = $part_svc->part_svc_column('typenum');
- push @label, ( $typenum_label && $typenum_label->columnlabel || 'Type:' ).
- $type->description;
+ push @label, ( $typenum_label && $typenum_label->columnlabel || 'Type' ).
+ ':'. $type->description;
}
if (my $ser = $self->serial) {
my $serial_label = $part_svc->part_svc_column('serial');
- push @label, ( $serial_label && $serial_label->columnlabel || 'Serial#' ).
- $ser;
+ push @label, ( $serial_label && $serial_label->columnlabel || 'Serial' ).
+ '#'. $ser;
}
if (my $mac = $self->display_hw_addr) {
my $hw_addr_label = $part_svc->part_svc_column('hw_addr');
- push @label, ( $hw_addr_label && $hw_addr_label->columnlabel || 'MAC:').
- $mac;
+ push @label, ( $hw_addr_label && $hw_addr_label->columnlabel || 'MAC').
+ ':'. $mac;
}
return join(', ', @label);
}
$hw_addr = uc($hw_addr);
$hw_addr =~ /^[0-9A-F]{12}$/
or return "Illegal (MAC address) '".$self->getfield('hw_addr')."'";
+ } else {
+ return "Illegal (hardware address) '".$self->getfield('hw_addr')."': ".
+ "12 alphanumeric characters maximum"
+ if length($hw_addr) > 12;
}
$self->setfield('hw_addr', $hw_addr);
$self->SUPER::check;
}
+#false laziness w/svc_cable
+sub _check_duplicate {
+ my $self = shift;
+
+ # Not reliable checks because the table isn't locked, but that's why we have
+ # unique indices. These are just to give friendlier error messages.
+
+ if ( $self->hw_addr ) {
+ my @dup_mac;
+ @dup_mac = $self->find_duplicates('global', 'hw_addr');
+ if ( @dup_mac ) {
+ return "Hardware address in use (svcnum ".$dup_mac[0]->svcnum.")";
+ }
+ }
+
+ if ( $self->ip_addr ) {
+ my @dup_ip;
+ @dup_ip = $self->find_duplicates('global', 'ip_addr');
+ if ( @dup_ip ) {
+ return "IP address in use (svcnum ".$dup_ip[0]->svcnum.")";
+ }
+ }
+
+ if ( $self->serial ) {
+ my @dup_serial;
+ @dup_serial = $self->find_duplicates('global', 'typenum', 'serial');
+ if ( @dup_serial ) {
+ return "Serial number in use (svcnum ".$dup_serial[0]->svcnum.")";
+ }
+ }
+
+ '';
+}
+
=item hardware_type
Returns the L<FS::hardware_type> object associated with this installation.