sub country_full {
my $self = shift;
- $self->code2country($self->country);
+ $self->code2country($self->get('country'));
}
sub code2country {
=cut
+# this is run from the job queue so I'm not transactionizing it.
+
sub process_district_update {
my $class = shift;
my $id = shift;
my %hash = map { $_ => $tax_info->{$_} }
qw( district city county state country );
- $hash{'taxname'} = '';
+ $hash{'source'} = $method; # apply the update only to taxes we maintain
+
+ my @old = qsearch('cust_main_county', \%hash);
+ if ( @old ) {
+ # prune any duplicates rather than updating them
+ my %keep; # key => cust_main_county record
+ foreach my $cust_main_county (@old) {
+ my $key = join('.', $cust_main_county->city ,
+ $cust_main_county->district ,
+ $cust_main_county->taxclass
+ );
+ if ( exists $keep{$key} ) {
+ my $disable_this = $cust_main_county;
+ # prefer records that have a tax name
+ if ( $cust_main_county->taxname and not $keep{$key}->taxname ) {
+ $disable_this = $keep{$key};
+ $keep{$key} = $cust_main_county;
+ }
+ # disable by setting the rate to zero, and setting source to null
+ # so it doesn't get auto-updated in the future. don't actually
+ # delete it, that produces orphan records
+ warn "disabling tax rate #" .
+ $disable_this->taxnum .
+ " because it's a duplicate for $key\n"
+ if $DEBUG;
+ # by setting its rate to zero, and never updating
+ # it again
+ $disable_this->set('tax' => 0);
+ $disable_this->set('source' => '');
+ $error = $disable_this->replace;
+ die $error if $error;
+ }
+
+ $keep{$key} ||= $cust_main_county;
- my $old = qsearchs('cust_main_county', \%hash);
- if ( $old ) {
- my $new = new FS::cust_main_county { $old->hash, %$tax_info };
- warn "updating tax rate for district ".$tax_info->{'district'} if $DEBUG;
- $error = $new->replace($old);
- }
- else {
+ }
+ foreach my $key (keys %keep) {
+ my $cust_main_county = $keep{$key};
+ warn "updating tax rate #".$cust_main_county->taxnum.
+ " for $key" if $DEBUG;
+ # update the tax rate only
+ $cust_main_county->set('tax', $tax_info->{'tax'});
+ $error ||= $cust_main_county->replace;
+ }
+ } else {
+ # make a new tax record, and mark it so we can find it later
+ $tax_info->{'source'} = $method;
my $new = new FS::cust_main_county $tax_info;
warn "creating tax rate for district ".$tax_info->{'district'} if $DEBUG;
$error = $new->insert;