while (my $item = $search->Next) {
my ($c, $a, $t) = map {lc $item->$_->Name}
('ScripConditionObj', 'ScripActionObj', 'TemplateObj');
- if ( exists $scrip{$c}{$a}{$t} and $item->Creator == 1 ) {
+ if ( exists $scrip{$c}{$a} and $item->Creator == 1 ) {
warn "Deleting duplicate scrip $c $a [$t]\n";
my ($val, $msg) = $item->Delete;
warn "error deleting scrip: $msg\n" if !$val;
warn "error deleting scrip: $msg\n" if !$val;
}
else {
- $scrip{$c}{$a}{$t} = $item->id;
+ $scrip{$c}{$a} = $item->id;
}
}
my $Scrip = RT::Scrip->new($CurrentUser);
my ($c, $a, $t) = map lc,
@{ $s }{'ScripCondition', 'ScripAction', 'Template'};
- if ( exists($scrip{$c}{$a}{$t}) ) {
- $Scrip->Load( $scrip{$c}{$a}{$t} );
+ if ( exists($scrip{$c}{$a}) ) {
+ $Scrip->Load( $scrip{$c}{$a} );
} else { # need to create it
if ( !exists($condition{$c}) ) {
}
}
- #Pg-specific
- my $cve_2013_3373_sql = q(
- UPDATE Tickets SET Subject = REPLACE(Subject,E'\n','')
- );
- #need this for mysql
- #UPDATE Tickets SET Subject = REPLACE(Subject,'\n','');
+ my $cve_2013_3373_sql = '';
+ if ( driver_name =~ /^Pg/i ) {
+ $cve_2013_3373_sql = q(
+ UPDATE Tickets SET Subject = REPLACE(Subject,E'\n','')
+ );
+ } elsif ( driver_name =~ /^mysql/i ) {
+ $cve_2013_3373_sql = q(
+ UPDATE Tickets SET Subject = REPLACE(Subject,'\n','');
+ );
+ } else {
+ warn "WARNING: Don't know how to update RT Ticket Subjects for your database driver for CVE-2013-3373";
+ }
+ if ( $cve_2013_3373_sql ) {
+ my $cve_2013_3373_sth = $dbh->prepare($cve_2013_3373_sql)
+ or die $dbh->errstr;
+ $cve_2013_3373_sth->execute
+ or die $cve_2013_3373_sth->errstr;
+ }
- my $cve_2013_3373_sth = $dbh->prepare( $cve_2013_3373_sql)
- or die $dbh->errstr;
- $cve_2013_3373_sth->execute or die $cve_2013_3373_sth->errstr;
+ # Remove dangling customer links, if any
+ my %target_pkey = ('cust_main' => 'custnum', 'cust_svc' => 'svcnum');
+ for my $table (keys %target_pkey) {
+ my $pkey = $target_pkey{$table};
+ my $rows = $dbh->do(
+ "DELETE FROM links WHERE id IN(".
+ "SELECT links.id FROM links LEFT JOIN $table ON (links.target = ".
+ "'freeside://freeside/$table/' || $table.$pkey) ".
+ "WHERE links.target like 'freeside://freeside/$table/%' ".
+ "AND $table.$pkey IS NULL".
+ ")"
+ ) or die $dbh->errstr;
+ warn "Removed $rows dangling ticket-$table links\n" if $rows > 0;
+ }
+
+ # Fix ticket transactions on the Time* fields where the NewValue (or
+ # OldValue, though this is not known to happen) is an empty string
+ foreach (qw(newvalue oldvalue)) {
+ my $rows = $dbh->do(
+ "UPDATE transactions SET $_ = '0' WHERE objecttype='RT::Ticket' AND ".
+ "field IN ('TimeWorked', 'TimeEstimated', 'TimeLeft') AND $_ = ''"
+ ) or die $dbh->errstr;
+ warn "Fixed $rows transactions with empty time values\n" if $rows > 0;
+ }
return;
}