projects
/
Business-OnlinePayment.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fixup parameter passing, finish changing names & doco to match
[Business-OnlinePayment.git]
/
OnlinePayment.pm
diff --git
a/OnlinePayment.pm
b/OnlinePayment.pm
index
2e9d35d
..
2b4e17b
100644
(file)
--- a/
OnlinePayment.pm
+++ b/
OnlinePayment.pm
@@
-6,7
+6,7
@@
use Carp;
use Symbol;
require 5.005;
use Symbol;
require 5.005;
-
##
use Data::Dumper;
+use Data::Dumper;
#require Exporter;
#require Exporter;
@@
-32,8
+32,7
@@
my %fields = (
server => undef,
port => undef,
path => undef,
server => undef,
port => undef,
path => undef,
- risk_management => undef,
- risk_management_params => undef,
+ fraud_detect => undef,
server_response => undef,
maximum_risk => undef,
);
server_response => undef,
maximum_risk => undef,
);
@@
-73,7
+72,7
@@
sub new {
$self->{_child_submit} = \&$submit;
*{"${subclass}::submit"} = sub {
my $self = shift;
$self->{_child_submit} = \&$submit;
*{"${subclass}::submit"} = sub {
my $self = shift;
- $self->_pre_submit(
@_
);
+ $self->_pre_submit();
}
}
}
}
@@
-89,7
+88,7
@@
sub _risk_detect {
$risk_transaction->content( %parent_content );
$risk_transaction->submit();
if ($risk_transaction->is_success()) {
$risk_transaction->content( %parent_content );
$risk_transaction->submit();
if ($risk_transaction->is_success()) {
- if ( $risk_transaction->
risk_level <= $self->maximum_risk
()) {
+ if ( $risk_transaction->
fraud_score <= $self->maximum_fraud_score
()) {
$self->{_child_submit}->($self);
} else {
$self->is_success(0);
$self->{_child_submit}->($self);
} else {
$self->is_success(0);
@@
-103,41
+102,34
@@
sub _risk_detect {
sub _pre_submit{
my ($self) = @_;
sub _pre_submit{
my ($self) = @_;
- my $
risk_detection = $self->risk_managemen
t();
+ my $
fraud_detection = $self->fraud_detec
t();
#
# early return if user does not want optional risk mgt
#
#
# early return if user does not want optional risk mgt
#
- return $self->{_child_submit}->($self,@_) unless $
risk_detection && length $risk
_detection;
+ return $self->{_child_submit}->($self,@_) unless $
fraud_detection && length $fraud
_detection;
#
# Search for an appropriate FD module
#
#
# Search for an appropriate FD module
#
- foreach my $subclass ( q(Business::OnlinePayment::) . $
risk
_detection,
- q(Business::FraudDetect::).$
risk
_detection) {
+ foreach my $subclass ( q(Business::OnlinePayment::) . $
fraud
_detection,
+ q(Business::FraudDetect::).$
fraud
_detection) {
if (!defined(&$subclass)) {
eval "use $subclass";
if ($@) {
if (!defined(&$subclass)) {
eval "use $subclass";
if ($@) {
- Carp::croak("serious problem loading
risk
_detection module ($@)") unless
+ Carp::croak("serious problem loading
fraud
_detection module ($@)") unless
$@ =~ m/^Can\'t locate/;
} else {
$@ =~ m/^Can\'t locate/;
} else {
- my $risk_tx = bless ( { processor => $
risk
_detection } , $subclass );
+ my $risk_tx = bless ( { processor => $
fraud
_detection } , $subclass );
$risk_tx->build_subs(keys %fields);
if ($risk_tx->can('set_defaults')) {
$risk_tx->set_defaults();
}
$risk_tx->build_subs(keys %fields);
if ($risk_tx->can('set_defaults')) {
$risk_tx->set_defaults();
}
- my %risk_params = %{$self->risk_management_params()};
- foreach my $key ( keys %risk_params ) {
- my $value = $risk_params{$key};
- $key = lc($key);
- $key =~ s/^\-//;
- $risk_tx->build_subs($key);
- $risk_tx->$key($value);
- }
+ $risk_tx->_glean_parameters_from_parent($self);
return $self->_risk_detect($risk_tx);
}
}
return $self->_risk_detect($risk_tx);
}
}