projects
/
freeside.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
should fix "cant call method "setdefault" on an undefined value" errors, RT#10360
[freeside.git]
/
FS
/
FS
/
ClientAPI
/
Signup.pm
diff --git
a/FS/FS/ClientAPI/Signup.pm
b/FS/FS/ClientAPI/Signup.pm
index
ec45e79
..
7bbdaff
100644
(file)
--- a/
FS/FS/ClientAPI/Signup.pm
+++ b/
FS/FS/ClientAPI/Signup.pm
@@
-608,8
+608,6
@@
sub new_customer {
} else {
die "unknown signup service $svc_x";
}
} else {
die "unknown signup service $svc_x";
}
- my $y = $svc[0]->setdefault; # arguably should be in new method
- return { 'error' => $y } if $y && !ref($y);
if ($packet->{'mac_addr'} && $conf->exists('signup_server-mac_addr_svcparts'))
{
if ($packet->{'mac_addr'} && $conf->exists('signup_server-mac_addr_svcparts'))
{
@@
-628,15
+626,16
@@
sub new_customer {
'_password' => '', #blank as requested (set passwordmin to 0)
};
'_password' => '', #blank as requested (set passwordmin to 0)
};
- my $y = $svc->setdefault; # arguably should be in new method
- return { 'error' => $y } if $y && !ref($y);
-
push @svc, $svc;
}
push @svc, $svc;
}
- #$error = $svc->check;
- #return { 'error' => $error } if $error;
+ foreach my $svc ( @svc ) {
+ my $y = $svc->setdefault; # arguably should be in new method
+ return { 'error' => $y } if $y && !ref($y);
+ #$error = $svc->check;
+ #return { 'error' => $error } if $error;
+ }
#setup a job dependancy to delay provisioning
my $placeholder = new FS::queue ( {
#setup a job dependancy to delay provisioning
my $placeholder = new FS::queue ( {