don't enable 'Void invoices' by default, being overused in lieu of more accounting...

[freeside.git] / FS / FS / AccessRight.pm

diff --git a/FS/FS/AccessRight.pm b/FS/FS/AccessRight.pm
index 44235b1..9b9642e 100644 (file)
--- a/FS/FS/AccessRight.pm
+++ b/FS/FS/AccessRight.pm
@@ -85,6 +85,21 @@ assigned to users and/or groups.
 
 #well, this is what we have for now.  getting better.
 tie my %rights, 'Tie::IxHash',
 
 #well, this is what we have for now.  getting better.
 tie my %rights, 'Tie::IxHash',

+
+  ###
+  # contact rights
+  ###
+  'Contact and Prospect rights' => [
+    'New prospect',
+    'View prospect',
+    'Edit prospect',
+    'List prospects',
+    'Edit contact', #!
+    #'New contact',
+    #'View customer contacts',
+    #'List contacts',
+    'Generate quotation',
+  ],

   
   ###
   # basic customer rights
   
   ###
   # basic customer rights


@@ -94,12 +109,18 @@ tie my %rights, 'Tie::IxHash',
     'View customer',
     #'View Customer | View tickets',
     'Edit customer',
     'View customer',
     #'View Customer | View tickets',
     'Edit customer',

+    'Edit customer tags',
+    'Edit referring customer',

     'View customer history',
     'View customer history',

+    'Suspend customer',
+    'Unsuspend customer',

     'Cancel customer',
     'Complimentary customer', #aka users-allow_comp 
     'Cancel customer',
     'Complimentary customer', #aka users-allow_comp 

-    { rightname=>'Delete customer', desc=>"Enable customer deletions. Be very careful! Deleting a customer will remove all traces that this customer ever existed! It should probably only be used when auditing a legacy database. Normally, you cancel all of a customer's packages if they cancel service." }, #aka. deletecustomers
+    'Merge customer',
+    'Merge customer across agents',

     'Bill customer now', #NEW
     'Bulk send customer notices', #NEW
     'Bill customer now', #NEW
     'Bulk send customer notices', #NEW

+    { rightname=>'View customers of all agents', global=>1 },

   ],
   
   ###
   ],
   
   ###


@@ -109,20 +130,29 @@ tie my %rights, 'Tie::IxHash',
     'View customer packages', #NEW
     'Order customer package',
     'One-time charge',
     'View customer packages', #NEW
     'Order customer package',
     'One-time charge',

+    'Modify one-time charge',

     'Change customer package',
     'Change customer package',

+    'Detach customer package',

     'Bulk change customer packages',
     'Edit customer package dates',
     'Bulk change customer packages',
     'Edit customer package dates',

+    'Discount customer package', #NEW
+    'Custom discount customer package', #NEW

     'Customize customer package',
     'Suspend customer package',
     'Suspend customer package later',
     'Unsuspend customer package',
     'Cancel customer package immediately',
     'Cancel customer package later',
     'Customize customer package',
     'Suspend customer package',
     'Suspend customer package later',
     'Unsuspend customer package',
     'Cancel customer package immediately',
     'Cancel customer package later',

+    'Un-cancel customer package',

     'Delay suspension events',
     'Add on-the-fly cancel reason', #NEW
     'Add on-the-fly suspend reason', #NEW
     'Edit customer package invoice details', #NEW
     'Edit customer package comments', #NEW
     'Delay suspension events',
     'Add on-the-fly cancel reason', #NEW
     'Add on-the-fly suspend reason', #NEW
     'Edit customer package invoice details', #NEW
     'Edit customer package comments', #NEW

+    'Qualify service', #NEW
+    'Waive setup fee', #NEW
+    'View appointments', #NEWNEW
+    'Make appointment',

   ],
   
   ###
   ],
   
   ###


@@ -131,9 +161,12 @@ tie my %rights, 'Tie::IxHash',
   'Customer service rights' => [
     'View customer services', #NEW
     'Provision customer service',
   'Customer service rights' => [
     'View customer services', #NEW
     'Provision customer service',

+    'Bulk provision customer service',
+    'Bulk move customer services', #NEWNEW

     'Recharge customer service', #NEW
     'Unprovision customer service',
     'Change customer service', #NEWNEW
     'Recharge customer service', #NEW
     'Unprovision customer service',
     'Change customer service', #NEWNEW

+    'Edit password',

     'Edit usage', #NEW
     'Edit home dir', #NEW
     'Edit www config', #NEW
     'Edit usage', #NEW
     'Edit home dir', #NEW
     'Edit www config', #NEW


@@ -150,8 +183,11 @@ tie my %rights, 'Tie::IxHash',
   'Customer invoice / financial info rights' => [
     'View invoices',
     'Resend invoices', #NEWNEW
   'Customer invoice / financial info rights' => [
     'View invoices',
     'Resend invoices', #NEWNEW

-    'Delete invoices', #new, but no need to phase in
+    'Void invoices',
+    'Unvoid invoices',
+    'Delete invoices',

     'View customer tax exemptions', #yow
     'View customer tax exemptions', #yow

+    'Edit customer tax exemptions', #NEWNEW

     'Add customer tax adjustment', #new, but no need to phase in
     'View customer batched payments', #NEW
     'View customer pending payments', #NEW
     'Add customer tax adjustment', #new, but no need to phase in
     'View customer batched payments', #NEW
     'View customer pending payments', #NEW


@@ -163,15 +199,18 @@ tie my %rights, 'Tie::IxHash',
   # customer payment rights
   ###
   'Customer payment rights' => [
   # customer payment rights
   ###
   'Customer payment rights' => [

-    'Post payment',
+    'View payments',
+    { rightname=>'Post payment', desc=>'Make check or cash payments.' },
+    { rightname=>'Backdate payment', desc=>'Enable payments to be posted for days other than today.' },
+    'Post check payment',
+    'Post cash payment',

     'Post payment batch',
     'Apply payment', #NEWNEW
     { rightname=>'Unapply payment', desc=>'Enable "unapplication" of unclosed payments from specific invoices.' }, #aka. unapplypayments
     'Post payment batch',
     'Apply payment', #NEWNEW
     { rightname=>'Unapply payment', desc=>'Enable "unapplication" of unclosed payments from specific invoices.' }, #aka. unapplypayments

-    'Process payment',
-    { rightname=>'Refund payment', desc=>'Enable refund of existing customer payments.' },
-
+    { rightname=>'Process payment', desc=>'Process credit card or e-check payments' },
+    'Process credit card payment',
+    'Process Echeck payment',

     { rightname=>'Delete payment', desc=>'Enable deletion of unclosed payments. Be very careful!  Only delete payments that were data-entry errors, not adjustments.' }, #aka. deletepayments Optionally specify one or more comma-separated email addresses to be notified when a payment is deleted.
     { rightname=>'Delete payment', desc=>'Enable deletion of unclosed payments. Be very careful!  Only delete payments that were data-entry errors, not adjustments.' }, #aka. deletepayments Optionally specify one or more comma-separated email addresses to be notified when a payment is deleted.

-  

   ],
   
   ###
   ],
   
   ###


@@ -179,23 +218,31 @@ tie my %rights, 'Tie::IxHash',
   ###
   'Customer credit and refund rights' => [
     'Post credit',
   ###
   'Customer credit and refund rights' => [
     'Post credit',

+    'Credit line items', #NEWNEWNEW

     'Apply credit', #NEWNEW
     { rightname=>'Unapply credit', desc=>'Enable "unapplication" of unclosed credits.' }, #aka unapplycredits
     { rightname=>'Delete credit', desc=>'Enable deletion of unclosed credits. Be very careful!  Only delete credits that were data-entry errors, not adjustments.' }, #aka. deletecredits Optionally specify one or more comma-separated email addresses to be notified when a credit is deleted.
     'Apply credit', #NEWNEW
     { rightname=>'Unapply credit', desc=>'Enable "unapplication" of unclosed credits.' }, #aka unapplycredits
     { rightname=>'Delete credit', desc=>'Enable deletion of unclosed credits. Be very careful!  Only delete credits that were data-entry errors, not adjustments.' }, #aka. deletecredits Optionally specify one or more comma-separated email addresses to be notified when a credit is deleted.

+    'View refunds',

     { rightname=>'Post refund', desc=>'Enable posting of check and cash refunds.' },
     { rightname=>'Post refund', desc=>'Enable posting of check and cash refunds.' },

+    'Post check refund',
+    'Post cash refund',

 #    { rightname=>'Process refund', desc=>'Enable processing of generic credit card/ACH refunds (i.e. not associated with a specific prior payment).' },
 #    { rightname=>'Process refund', desc=>'Enable processing of generic credit card/ACH refunds (i.e. not associated with a specific prior payment).' },

+    { rightname=>'Refund payment', desc=>'Enable refund of existing customer credit card or e-check payments.' },
+    'Refund credit card payment',
+    'Refund Echeck payment',

     'Delete refund', #NEW
     'Add on-the-fly credit reason', #NEW
     'Delete refund', #NEW
     'Add on-the-fly credit reason', #NEW

+    'Add on-the-fly refund reason', #NEW

   ],
   
   ###
   # customer voiding rights..
   ###
   ],
   
   ###
   # customer voiding rights..
   ###

-  'Customer void rights' => [
-    { rightname=>'Credit card void', desc=>'Enable local-only voiding of echeck payments in addition to refunds against the payment gateway.' }, #aka. cc-void 
+  'Customer payment void rights' => [
+    { rightname=>'Credit card void', desc=>'Enable local-only voiding of credit card payments in addition to refunds against the payment gateway.' }, #aka. cc-void 

     { rightname=>'Echeck void', desc=>'Enable local-only voiding of echeck payments in addition to refunds against the payment gateway.' }, #aka. echeck-void
     { rightname=>'Echeck void', desc=>'Enable local-only voiding of echeck payments in addition to refunds against the payment gateway.' }, #aka. echeck-void

-    'Regular void',
-    { rightname=>'Unvoid', desc=>'Enable unvoiding of voided payments' }, #aka. unvoid 
+    'Void payments',
+    { rightname=>'Unvoid payments', desc=>'Enable unvoiding of voided payments' }, #aka. unvoid 

     
   
   ],
     
   
   ],


@@ -206,7 +253,8 @@ tie my %rights, 'Tie::IxHash',
   'Customer note and attachment rights' => [
     'Add customer note', #NEW
     'Edit customer note', #NEW
   'Customer note and attachment rights' => [
     'Add customer note', #NEW
     'Edit customer note', #NEW

-    'View attachments',
+    'View attachments', #NEW
+    'Browse attachments', #NEW

     'Download attachment', #NEW
     'Add attachment', #NEW
     'Edit attachment', #NEW
     'Download attachment', #NEW
     'Add attachment', #NEW
     'Edit attachment', #NEW


@@ -221,15 +269,55 @@ tie my %rights, 'Tie::IxHash',
   ###
   'Reporting/listing rights' => [
     'List customers',
   ###
   'Reporting/listing rights' => [
     'List customers',

+    'List all customers',
+    'Advanced customer search',

     'List zip codes', #NEW
     'List zip codes', #NEW

+    'List quotations',

     'List invoices',
     'List packages',
     'List invoices',
     'List packages',

+    'Summarize packages',

     'List services',
     'List services',

+    'List service passwords',

   
     { rightname=> 'List rating data', desc=>'Usage reports', global=>1 },
     'Billing event reports',
     'Receivables report',
     'Financial reports',
   
     { rightname=> 'List rating data', desc=>'Usage reports', global=>1 },
     'Billing event reports',
     'Receivables report',
     'Financial reports',

+    { rightname=> 'List inventory', global=>1 },
+    { rightname=>'View email logs', global=>1 },
+    { rightname=>'View system logs' },
+
+    'Download report data',
+    'Services: Accounts',
+    'Services: Accounts: Advanced search',
+    'Services: Domains',
+    'Services: Certificates',
+    'Services: Mail forwards',
+    'Services: Virtual hosting services',
+    'Services: Wireless broadband services',
+    'Services: Wireless broadband services: Advanced search',
+    'Services: DSLs',
+    'Services: Cable subscribers',
+    'Services: Conferencing',
+    'Services: Dish services',
+    'Services: Hardware',
+    'Services: Hardware: Advanced search',
+    'Services: Phone numbers',
+    'Services: Phone numbers: Advanced search',
+    'Services: PBXs',
+    'Services: Ports',
+    'Services: Mailing lists',
+    'Services: Alarm services',
+    'Services: Video',
+    'Services: External services',
+    'Usage: RADIUS sessions',
+    'Usage: Call Detail Records (CDRs)',
+    'Usage: Unrateable CDRs',
+    'Usage: Time worked',
+    #gone in 4.x as a distinct ACL (for now?) { rightname=>'Employees: Commission Report', global=>1 },
+    { rightname=>'Employees: Audit Report', global=>1 },
+
+    #{ rightname => 'List customers of all agents', global=>1 },

   ],
   
   ###
   ],
   
   ###


@@ -238,9 +326,12 @@ tie my %rights, 'Tie::IxHash',
   'Miscellaneous rights' => [
     { rightname=>'Job queue', global=>1 },
     { rightname=>'Time queue', global=>1 },
   'Miscellaneous rights' => [
     { rightname=>'Job queue', global=>1 },
     { rightname=>'Time queue', global=>1 },

-    { rightname=>'Process batches', global=>1 },
-    { rightname=>'Reprocess batches', global=>1 },
-    { rightname=>'Redownload resolved batches', global=>1 },
+    { rightname=>'Process batches', }, #Process payment batches
+    { rightname=>'Process global batches', global=>1 }, #Process global payment batches
+    { rightname=>'Reprocess batches', global=>1 }, #Reprocess payment batches
+    { rightname=>'Redownload resolved batches', global=>1 }, #Redownload resolved payment batches
+    { rightname=>'Process invoice batches', },
+    { rightname=>'Process global invoice batches', global=>1 },

     { rightname=>'Import', global=>1 }, #some of these are ag-virt'ed now?  give em their own ACLs
     { rightname=>'Export', global=>1 },
     { rightname=> 'Edit rating data', desc=>'Delete CDRs', global=>1 },
     { rightname=>'Import', global=>1 }, #some of these are ag-virt'ed now?  give em their own ACLs
     { rightname=>'Export', global=>1 },
     { rightname=> 'Edit rating data', desc=>'Delete CDRs', global=>1 },


@@ -260,11 +351,30 @@ tie my %rights, 'Tie::IxHash',
     'Edit advertising sources',
     { rightname=>'Edit global advertising sources', global=>1 },
 
     'Edit advertising sources',
     { rightname=>'Edit global advertising sources', global=>1 },
 

+    'Edit sales people',
+

     'Edit package definitions',
     { rightname=>'Edit global package definitions', global=>1 },
     'Edit package definitions',
     { rightname=>'Edit global package definitions', global=>1 },

-  
+    'Edit package definition costs',
+
+    'Bulk edit package definitions',
+
+    'Edit CDR rates',
+    #{ rightname=>'Edit global CDR rates', global=>1, },
+
+    'Edit fee definitions',
+    { rightname=>'Edit global fee definitions', global=>1 },
+

     'Edit billing events',
     { rightname=>'Edit global billing events', global=>1 },
     'Edit billing events',
     { rightname=>'Edit global billing events', global=>1 },

+
+    'View templates',
+    { rightname=>'View global templates', global=>1 },
+    'Edit templates',
+    { rightname=>'Edit global templates', global=>1 },
+
+    'Edit inventory',
+    { rightname=>'Edit global inventory', global=>1 },

   
     { rightname=>'Dialup configuration' },
     { rightname=>'Dialup global configuration', global=>1 },
   
     { rightname=>'Dialup configuration' },
     { rightname=>'Dialup global configuration', global=>1 },


@@ -272,6 +382,14 @@ tie my %rights, 'Tie::IxHash',
     { rightname=>'Broadband configuration' },
     { rightname=>'Broadband global configuration', global=>1 },
 
     { rightname=>'Broadband configuration' },
     { rightname=>'Broadband global configuration', global=>1 },
 

+    { rightname=>'Alarm configuration' },
+    { rightname=>'Alarm global configuration', global=>1 },
+
+    { rightname=> 'Configure network monitoring', global=>1 },
+
+    #{ rightname=>'Edit employees', global=>1, },
+    #{ rightname=>'Edit employee groupss', global=>1, },
+

     { rightname=>'Configuration', global=>1 }, #most of the rest of the configuraiton is not agent-virtualized
 
     { rightname=>'Configuration download', }, #description of how it affects
     { rightname=>'Configuration', global=>1 }, #most of the rest of the configuraiton is not agent-virtualized
 
     { rightname=>'Configuration download', }, #description of how it affects


@@ -305,15 +423,22 @@ Most (but not all) right names.
 sub default_superuser_rights {
   my $class = shift;
   my %omit = map { $_=>1 } (
 sub default_superuser_rights {
   my $class = shift;
   my %omit = map { $_=>1 } (

-    'Delete customer',

     'Delete invoices',
     'Delete payment',
     'Delete credit', #?
     'Delete refund', #?
     'Delete invoices',
     'Delete payment',
     'Delete credit', #?
     'Delete refund', #?

+    'Edit customer package dates',

     'Time queue',
     'Time queue',

+    'Usage: Time worked',

     'Redownload resolved batches',
     'Raw SQL',
     'Configuration download',
     'Redownload resolved batches',
     'Raw SQL',
     'Configuration download',

+    'View customers of all agents',
+    'View/link unlinked services',
+    'Edit usage',
+    'Credit card void',
+    'Echeck void',
+    'Void invoices',#people are overusing this when credits are more appropriate

   );
 
   no warnings 'uninitialized';
   );
 
   no warnings 'uninitialized';