summaryrefslogtreecommitdiff
path: root/rt/lib/RT/GroupMember_Overlay.pm
diff options
context:
space:
mode:
Diffstat (limited to 'rt/lib/RT/GroupMember_Overlay.pm')
-rw-r--r--rt/lib/RT/GroupMember_Overlay.pm34
1 files changed, 9 insertions, 25 deletions
diff --git a/rt/lib/RT/GroupMember_Overlay.pm b/rt/lib/RT/GroupMember_Overlay.pm
index d824dc4b3..5ff7b3e7f 100644
--- a/rt/lib/RT/GroupMember_Overlay.pm
+++ b/rt/lib/RT/GroupMember_Overlay.pm
@@ -1,8 +1,8 @@
-# BEGIN BPS TAGGED BLOCK {{{
+# {{{ BEGIN BPS TAGGED BLOCK
#
# COPYRIGHT:
#
-# This software is Copyright (c) 1996-2005 Best Practical Solutions, LLC
+# This software is Copyright (c) 1996-2004 Best Practical Solutions, LLC
# <jesse@bestpractical.com>
#
# (Except where explicitly superseded by other copyright notices)
@@ -42,8 +42,7 @@
# works based on those contributions, and sublicense and distribute
# those contributions and any derivatives thereof.
#
-# END BPS TAGGED BLOCK }}}
-
+# }}} END BPS TAGGED BLOCK
=head1 NAME
RT::GroupMember - a member of an RT Group
@@ -73,9 +72,6 @@ ok (require RT::GroupMember);
=cut
-
-package RT::GroupMember;
-
use strict;
no warnings qw(redefine);
use RT::CachedGroupMembers;
@@ -124,7 +120,7 @@ sub Create {
#Clear the key cache. TODO someday we may want to just clear a little bit of the keycache space.
# TODO what about the groups key cache?
- RT::Principal->InvalidateACLCache();
+ RT::Principal->_InvalidateACLCache();
$RT::Handle->BeginTransaction() unless ($args{'InsideTransaction'});
@@ -233,7 +229,7 @@ sub _StashUser {
#Clear the key cache. TODO someday we may want to just clear a little bit of the keycache space.
# TODO what about the groups key cache?
- RT::Principal->InvalidateACLCache();
+ RT::Principal->_InvalidateACLCache();
# We really need to make sure we don't add any members to this group
@@ -307,6 +303,9 @@ sub Delete {
VALUE => $self->GroupObj->Id
);
+ #Clear the key cache. TODO someday we may want to just clear a little bit of the keycache space.
+ # TODO what about the groups key cache?
+ RT::Principal->_InvalidateACLCache();
@@ -320,27 +319,12 @@ sub Delete {
}
}
- my ($err, $msg) = $self->SUPER::Delete();
+ my $err = $self->SUPER::Delete();
unless ($err) {
$RT::Logger->warning("Couldn't delete cached group submember ".$self->Id);
$RT::Handle->Rollback();
return (undef);
}
-
- # Since this deletion may have changed the former member's
- # delegation rights, we need to ensure that no invalid delegations
- # remain.
- $err = $self->MemberObj->_CleanupInvalidDelegations(InsideTransaction => 1);
- unless ($err) {
- $RT::Logger->warning("Unable to revoke delegated rights for principal ".$self->Id);
- $RT::Handle->Rollback();
- return (undef);
- }
-
- #Clear the key cache. TODO someday we may want to just clear a little bit of the keycache space.
- # TODO what about the groups key cache?
- RT::Principal->InvalidateACLCache();
-
$RT::Handle->Commit();
return ($err);