diff options
| -rw-r--r-- | FS/FS/cust_bill.pm | 31 |
1 files changed, 17 insertions, 14 deletions
diff --git a/FS/FS/cust_bill.pm b/FS/FS/cust_bill.pm index b694924f3..7ea586a90 100644 --- a/FS/FS/cust_bill.pm +++ b/FS/FS/cust_bill.pm @@ -253,7 +253,7 @@ sub void { } } - $error = $self->delete; + $error = $self->_delete; if ( $error ) { $dbh->rollback if $oldAutoCommit; return $error; @@ -265,19 +265,22 @@ sub void { } -=item delete - -DO NOT USE THIS METHOD. Instead, apply a credit against the invoice, or use -the B<void> method. - -This is only for internal use by V<void>, which is what you should be using. - -DO NOT USE THIS METHOD. Whatever reason you think you have is almost certainly -wrong. Use B<void>, that's what it is for. Really. This means you. - -=cut - -sub delete { +# removed docs entirely and renamed method to _delete to further indicate it is +# internal-only and discourage use +# +# =item delete +# +# DO NOT USE THIS METHOD. Instead, apply a credit against the invoice, or use +# the B<void> method. +# +# This is only for internal use by V<void>, which is what you should be using. +# +# DO NOT USE THIS METHOD. Whatever reason you think you have is almost certainly +# wrong. Use B<void>, that's what it is for. Really. This means you. +# +# =cut + +sub _delete { my $self = shift; return "Can't delete closed invoice" if $self->closed =~ /^Y/i; |