diff options
| author | ivan <ivan> | 2009-12-31 13:16:41 +0000 |
|---|---|---|
| committer | ivan <ivan> | 2009-12-31 13:16:41 +0000 |
| commit | 63a268637b2d51a8766412617724b9436439deb6 (patch) | |
| tree | a50f6d4c7829d5c80905e989144317192a44dc90 /rt/lib/RT/StyleGuide.pod | |
| parent | 65a561e3cd8c1ba94f6282f5d2a1cd9783afbd21 (diff) | |
| parent | b4b0c7e72d7eaee2fbfc7022022c9698323203dd (diff) | |
This commit was generated by cvs2svn to compensate for changes in r8690,
which included commits to RCS files with non-trunk default branches.
Diffstat (limited to 'rt/lib/RT/StyleGuide.pod')
| -rw-r--r-- | rt/lib/RT/StyleGuide.pod | 24 |
1 files changed, 9 insertions, 15 deletions
diff --git a/rt/lib/RT/StyleGuide.pod b/rt/lib/RT/StyleGuide.pod index ff9a1b5d0..84ccb89df 100644 --- a/rt/lib/RT/StyleGuide.pod +++ b/rt/lib/RT/StyleGuide.pod @@ -262,20 +262,14 @@ style perfectly; we are trying to fix it without breaking exsiting APIs. =head2 Tests Modules should provide test code, with documentation on how to use -it. Test::Inline allows tests to be embedded in code. Test::More makes it -easy to create tests. Any code you write should have a testsuite. -Any code you alter should have a test suite. If a patch comes in without -tests, there is something wrong. - -When altering code, you must run the test harness before submitting a patch -or committing code to the repository. - -"make regression" will extract inline tests, blow away the system database -and run the test suite. - -"make regression-quiet" will do all that and not print the "ok" lines. +it. Test::More makes it easy to create tests. Any code you write +should have a testsuite. Any code you alter should have a test +suite. If a patch comes in without tests, there is something wrong. +When altering code, you must run the test harness before submitting a +patch or committing code to the repository. +"make test" will run the test suite. =head2 STDIN/STDOUT @@ -787,11 +781,11 @@ should become <&|/l, $m->scomp('/Elements/SelectNewTicketQueue')&><input type=" -The string <& /Elements/TitleBoxStart, width=> "40%", titleright => "RT $RT::VERSION for $RT::rtname", title => 'Login' &> +The string <& /Elements/TitleBoxStart, width=> "40%", titleright => "RT $RT::VERSION for RT->Config->Get('rtname')", title => 'Login' &> should become <& /Elements/TitleBoxStart, width=> "40%", - titleright => loc("RT [_1] for [_2]",$RT::VERSION, $RT::rtname), + titleright => loc("RT [_1] for [_2]",$RT::VERSION, RT->Config->Get('rtname')), title => loc('Login'), &> @@ -816,7 +810,7 @@ should become return $self->loc( "Subject changed to [_1]", $self->Data ); It is important not to localize the names of rights or statuses within RT's core, as there is logic that depends on them as string identifiers. The proper place to localize these values is when they're presented for display in the web or commandline interfaces. -=back 4 +=back =head1 CODING PRCEDURE |