diff options
author | Ivan Kohler <ivan@freeside.biz> | 2015-07-09 22:18:55 -0700 |
---|---|---|
committer | Ivan Kohler <ivan@freeside.biz> | 2015-07-09 22:27:04 -0700 |
commit | e131b1f71f08b69abb832c1687d1f29682d171f8 (patch) | |
tree | 490167e41d9fe05b760e7b21a96ee35a86f8edda /rt/.perlcriticrc | |
parent | d05d7346bb2387fd9d0354923d577275c5c7f019 (diff) |
RT 4.2.11, ticket#13852
Diffstat (limited to 'rt/.perlcriticrc')
-rw-r--r-- | rt/.perlcriticrc | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/rt/.perlcriticrc b/rt/.perlcriticrc index 9cf8f633f..14246309a 100644 --- a/rt/.perlcriticrc +++ b/rt/.perlcriticrc @@ -4,3 +4,23 @@ exclude = Subroutines::ProhibitExplicitReturnUndef Modules::RequireFilenameMatchesPackage TestingAndDebugging::ProhibitNoStrict color = 1 verbose = 7 + + +# we don't unpack @_ right away as we mostly use named vars with defaults: +# sub foo { +# my $self = shift; +# my %args = ( default => 'value', ..., @_ ); +# ... +[-Subroutines::RequireArgUnpacking] + +# Readonly superiority is not convincing, especially considering +# that 'use constant' participates in constants folding during +# compilation +[-ValuesAndExpressions::ProhibitConstantPragma] + +# brutal +[BuiltinFunctions::RequireBlockGrep] +severity = 1 + +[BuiltinFunctions::RequireBlockMap] +severity = 1 |