summaryrefslogtreecommitdiff
path: root/httemplate/view/elements
diff options
context:
space:
mode:
authorIvan Kohler <ivan@freeside.biz>2015-12-09 16:56:15 -0800
committerIvan Kohler <ivan@freeside.biz>2015-12-09 16:56:15 -0800
commit85d7ec5cab08971dd80447c3cc62e962ba6227d5 (patch)
tree899e73bec5790da6ec46727b3c9f59416aff5ea8 /httemplate/view/elements
parent0efd28a530593574f40dcfab69eaae2b3f0da388 (diff)
deal when Net::MAC::Vendor-lookup doesn't return an arrayref, RT#39384
Diffstat (limited to 'httemplate/view/elements')
-rw-r--r--httemplate/view/elements/svc_Common.html4
-rw-r--r--httemplate/view/elements/svc_radius_usage.html7
2 files changed, 7 insertions, 4 deletions
diff --git a/httemplate/view/elements/svc_Common.html b/httemplate/view/elements/svc_Common.html
index 771bfb276..207838759 100644
--- a/httemplate/view/elements/svc_Common.html
+++ b/httemplate/view/elements/svc_Common.html
@@ -283,8 +283,8 @@ my $format_field = sub {
} elsif ( $type eq 'checkbox' ) {
$value = $value eq 'Y' ? emt('Yes') : emt('No');
} elsif ( $type =~ /(input-)?mac_addr/ and $value =~ /\w/) {
- my $vendor = Net::MAC::Vendor::lookup($value)->[0];
- $value .= " ($vendor)" if $vendor;
+ my $vendor = Net::MAC::Vendor::lookup($value);
+ $value .= ' ('. $vendor->[0]. ')' if $vendor;
$value = $m->scomp('/elements/mac_addr.html', $value);
}
diff --git a/httemplate/view/elements/svc_radius_usage.html b/httemplate/view/elements/svc_radius_usage.html
index 08d6d53d3..5a958ee76 100644
--- a/httemplate/view/elements/svc_radius_usage.html
+++ b/httemplate/view/elements/svc_radius_usage.html
@@ -27,8 +27,11 @@
% ) / 1048576;
%
% my $last_mac = $svc->attribute_last_sqlradacct( 'CallingStationId' );
-% if ( $last_mac =~ /^\s*(([\dA-F]{2}[\-:]){5}[\dA-F]{2})/i ) {
-% $last_mac .= ' ('. (Net::MAC::Vendor::lookup($1))->[0]. ')';
+% if ( $last_mac =~ /^\s*(([\dA-F]{2}[\-:]){5}[\dA-F]{2})/i
+% && my $vendor = Net::MAC::Vendor::lookup($1)
+% )
+% {
+% $last_mac .= ' ('. $vendor->[0]. ')';
% }