summaryrefslogtreecommitdiff
path: root/httemplate/misc/process
diff options
context:
space:
mode:
authorivan <ivan>2007-07-13 23:52:23 +0000
committerivan <ivan>2007-07-13 23:52:23 +0000
commit9035034a53d60cb7a7687dfee899c1d0c775ea74 (patch)
tree80a6dc3d257fa24b2097746e4b8f074a420dfdd9 /httemplate/misc/process
parentae5b57a84d549166bae637c0c01db0b9e09b138f (diff)
fix race condition where ->apply_payments_and_credits could double-apply in rare cases
Diffstat (limited to 'httemplate/misc/process')
-rwxr-xr-xhttemplate/misc/process/recharge_svc.html2
1 files changed, 1 insertions, 1 deletions
diff --git a/httemplate/misc/process/recharge_svc.html b/httemplate/misc/process/recharge_svc.html
index dc9d5ea2d..bc916e5da 100755
--- a/httemplate/misc/process/recharge_svc.html
+++ b/httemplate/misc/process/recharge_svc.html
@@ -57,7 +57,7 @@
%
% my $old_balance = $cust_main->balance;
% $error ||= $cust_main->bill;
-% $cust_main->apply_payments_and_credits unless $error;
+% $error ||= $cust_main->apply_payments_and_credits;
% my $bill_error = $cust_main->collect('realtime' => 1) unless $error;
% $error ||= "Failed to collect - $bill_error"
% if $cust_main->balance > $old_balance && $cust_main->balance > 0