diff options
author | Ivan Kohler <ivan@freeside.biz> | 2017-01-31 18:37:06 -0800 |
---|---|---|
committer | Ivan Kohler <ivan@freeside.biz> | 2018-09-13 15:27:25 -0700 |
commit | f25731325e3f80699074032165cd1bd0a5d6ccba (patch) | |
tree | a93b6aa2736c802d703c4e417a2c4bb00dc45b39 /FS/FS/part_event | |
parent | a0492f2b5d28bf1012d0b47c25d20891d58c4ca6 (diff) |
add condition_sql optimization to "Customer has a referring customer with uncancelled specific package(s)" condition, RT#74456
Diffstat (limited to 'FS/FS/part_event')
-rw-r--r-- | FS/FS/part_event/Condition/has_referral_pkgpart.pm | 21 |
1 files changed, 16 insertions, 5 deletions
diff --git a/FS/FS/part_event/Condition/has_referral_pkgpart.pm b/FS/FS/part_event/Condition/has_referral_pkgpart.pm index 4409444..4c3681e 100644 --- a/FS/FS/part_event/Condition/has_referral_pkgpart.pm +++ b/FS/FS/part_event/Condition/has_referral_pkgpart.pm @@ -18,6 +18,8 @@ sub option_fields { ); } +#lots of falze laziness w/has_pkgpart.. + sub condition { my($self, $object, %opt) = @_; @@ -27,14 +29,23 @@ sub condition { my $if_pkgpart = $self->option('if_pkgpart') || {}; grep $if_pkgpart->{ $_->pkgpart }, - $cust_main->referral_custnum_cust_main->ncancelled_pkgs; + $cust_main->referral_custnum_cust_main->ncancelled_pkgs( 'skip_label_sort'=> 1); #maybe billing_pkgs } -#XXX -#sub condition_sql { -# -#} +sub condition_sql { + my( $self, $table ) = @_; + + 'ARRAY'. $self->condition_sql_option_option_integer('if_pkgpart'). + ' && '. #overlap (have elements in common) + 'ARRAY( SELECT pkgpart FROM cust_pkg AS has_referral_pkgpart_cust_pkg + WHERE has_referral_pkgpart_cust_pkg.custnum = cust_main.referral_custnum + AND ( has_referral_pkgpart_cust_pkg.cancel IS NULL + OR has_referral_pkgpart_cust_pkg.cancel = 0 + ) + ) + '; +} 1; |