diff options
| author | Jonathan Prykop <jonathan@freeside.biz> | 2016-06-27 22:40:44 -0500 |
|---|---|---|
| committer | Jonathan Prykop <jonathan@freeside.biz> | 2016-06-28 06:49:54 -0500 |
| commit | fc9879b7cb4b1f0b4fefe850e2901e3f9a74f63b (patch) | |
| tree | 2f19a4b446dc589fc6f5a13c2030a38a3d0bf88a | |
| parent | 2164bf38a61edc4fd84240214a41549847751e40 (diff) | |
RT#15006: Bug? Cancelled customers shown in reports?
| -rw-r--r-- | FS/FS/cust_main.pm | 13 | ||||
| -rwxr-xr-x | httemplate/search/cust_main.cgi | 2 |
2 files changed, 5 insertions, 10 deletions
diff --git a/FS/FS/cust_main.pm b/FS/FS/cust_main.pm index 8e96b4273..6c4374766 100644 --- a/FS/FS/cust_main.pm +++ b/FS/FS/cust_main.pm @@ -4997,15 +4997,10 @@ Returns an SQL expression identifying un-cancelled cust_main records. =cut sub uncancelled_sql { uncancel_sql(@_); } -sub uncancel_sql { " - ( 0 < ( $select_count_pkgs - AND ( cust_pkg.cancel IS NULL - OR cust_pkg.cancel = 0 - ) - ) - OR 0 = ( $select_count_pkgs ) - ) -"; } +sub uncancel_sql { + my $self = shift; + "( NOT (".$self->cancelled_sql.") )"; #sensitive to cust_main-status_module +} =item balance_sql diff --git a/httemplate/search/cust_main.cgi b/httemplate/search/cust_main.cgi index 62231a120..da6c89d44 100755 --- a/httemplate/search/cust_main.cgi +++ b/httemplate/search/cust_main.cgi @@ -501,7 +501,7 @@ if ( $cgi->param('browse') ); } - @cust_main = grep { $_->num_ncancelled_pkgs || ! $_->num_pkgs } @cust_main + @cust_main = grep { $_->status ne 'cancelled' } @cust_main if ! $cgi->param('cancelled') && ( $cgi->param('showcancelledcustomers') eq '0' #see if it was set by me |