diff options
| author | ivan <ivan> | 2002-01-24 11:52:02 +0000 |
|---|---|---|
| committer | ivan <ivan> | 2002-01-24 11:52:02 +0000 |
| commit | ef5490483c6b97512c4a1fe0ec841c2044e346af (patch) | |
| tree | fdb75f551a6eade341fb26e00bae369fb8e97876 | |
| parent | 9bf94801a1dd34dadf2862b52886e1257995ef08 (diff) | |
jeff's on a bugfinding roll here, thanks!
| -rw-r--r-- | FS/FS/cust_credit_refund.pm | 3 | ||||
| -rw-r--r-- | FS/FS/cust_pay.pm | 3 | ||||
| -rw-r--r-- | FS/FS/cust_refund.pm | 6 |
3 files changed, 7 insertions, 5 deletions
diff --git a/FS/FS/cust_credit_refund.pm b/FS/FS/cust_credit_refund.pm index cf16284bc..8b7d6dac3 100644 --- a/FS/FS/cust_credit_refund.pm +++ b/FS/FS/cust_credit_refund.pm @@ -179,12 +179,11 @@ sub cust_refund { qsearchs( 'cust_credit', { 'crednum' => $self->crednum } ); } - =back =head1 VERSION -$Id: cust_credit_refund.pm,v 1.5 2002-01-24 11:43:39 ivan Exp $ +$Id: cust_credit_refund.pm,v 1.6 2002-01-24 11:52:02 ivan Exp $ =head1 BUGS diff --git a/FS/FS/cust_pay.pm b/FS/FS/cust_pay.pm index b96e29fbd..00c6e1cfe 100644 --- a/FS/FS/cust_pay.pm +++ b/FS/FS/cust_pay.pm @@ -251,6 +251,7 @@ sub check { $self->payby =~ /^(CARD|BILL|COMP)$/ or return "Illegal payby"; $self->payby($1); + #false laziness with cust_refund::check if ( $self->payby eq 'CARD' ) { my $payinfo = $self->payinfo; $payinfo =~ s/\D//g; @@ -306,7 +307,7 @@ sub unapplied { =head1 VERSION -$Id: cust_pay.pm,v 1.11 2002-01-22 15:57:33 ivan Exp $ +$Id: cust_pay.pm,v 1.12 2002-01-24 11:52:02 ivan Exp $ =head1 BUGS diff --git a/FS/FS/cust_refund.pm b/FS/FS/cust_refund.pm index c7d8a6d62..a1d1e594c 100644 --- a/FS/FS/cust_refund.pm +++ b/FS/FS/cust_refund.pm @@ -232,9 +232,11 @@ sub check { $self->payby =~ /^(CARD|BILL|COMP)$/ or return "Illegal payby"; $self->payby($1); + #false laziness with cust_pay::check if ( $self->payby eq 'CARD' ) { my $payinfo = $self->payinfo; - $self->payinfo($payinfo =~ s/\D//g); + $payinfo =~ s/\D//g; + $self->payinfo($payinfo); if ( $self->payinfo ) { $self->payinfo =~ /^(\d{13,16})$/ or return "Illegal (mistyped?) credit card number (payinfo)"; @@ -259,7 +261,7 @@ sub check { =head1 VERSION -$Id: cust_refund.pm,v 1.12 2002-01-24 06:52:44 ivan Exp $ +$Id: cust_refund.pm,v 1.13 2002-01-24 11:52:02 ivan Exp $ =head1 BUGS |