summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMark Wells <mark@freeside.biz>2016-06-03 17:45:04 -0700
committerMark Wells <mark@freeside.biz>2016-06-03 17:45:21 -0700
commitcf630a513689c8a176a6a552fcbcba844a0d5b76 (patch)
treeb123c3038f4bd626484fd2c8a749374474cbe5bf
parent1ceeee1c6b8c46805c103fbcfc1bbee768b12609 (diff)
calculate unitrecur on sql_external packages with quantity details, #40558
-rw-r--r--FS/FS/cust_main/Billing.pm1
-rw-r--r--FS/FS/part_pkg/sql_external.pm3
2 files changed, 2 insertions, 2 deletions
diff --git a/FS/FS/cust_main/Billing.pm b/FS/FS/cust_main/Billing.pm
index 47a3dc2..d953767 100644
--- a/FS/FS/cust_main/Billing.pm
+++ b/FS/FS/cust_main/Billing.pm
@@ -1172,6 +1172,7 @@ sub _make_lines {
if ( $param{'override_quantity'} ) {
$override_quantity = $param{'override_quantity'};
+ $unitrecur = $recur / $override_quantity;
}
if ( $increment_next_bill ) {
diff --git a/FS/FS/part_pkg/sql_external.pm b/FS/FS/part_pkg/sql_external.pm
index 6760634..9bf107b 100644
--- a/FS/FS/part_pkg/sql_external.pm
+++ b/FS/FS/part_pkg/sql_external.pm
@@ -96,8 +96,7 @@ sub calc_recur {
die "sql_external query returned non-numeric amount: $row->{amount}";
}
}
- if (exists $row->{quantity}) {
- $quantity ||= 0;
+ if (defined $row->{quantity}) {
if ( $row->{quantity} eq '' ) {
# treat as zero
} elsif ( $row->{quantity} =~ /^\d+$/ ) {