summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Houghton <houghton@freeside.biz>2014-09-10 16:54:37 -0400
committerDavid Houghton <houghton@freeside.biz>2014-09-10 16:59:52 -0400
commitcabd4b54169356d298b05c826c3fd549c2fb22bf (patch)
treeefd81b7f7fe97661a7b69b1d2773776cb53af795
parent55a9939e17ab945d00336317b9842f17cc27ba6e (diff)
ticket: 27309; use dbh->quote
Sorry, I shouldn't have missed this. I've gotten used to using either DBIx::Class to construct queries for me or using whole prepared statements, which handle the quoting automagically. I've gotten out of practice with SQL created piecemeal.
-rw-r--r--httemplate/search/cdr.html8
1 files changed, 3 insertions, 5 deletions
diff --git a/httemplate/search/cdr.html b/httemplate/search/cdr.html
index 10b386383..778799b1f 100644
--- a/httemplate/search/cdr.html
+++ b/httemplate/search/cdr.html
@@ -264,11 +264,9 @@ if ( $cgi->param('acctid') =~ /\d/ ) {
if ( $cgi->param('accountcode') =~ /\S/ ) {
my $accountcode = $cgi->param('accountcode');
my @accountcode = map {
- ( my $v = $_ ) =~ s/^\s+|\s+$//g;
- if ( $v =~ /'/ ) { $v =~ s/'/\\'/g; $v = "E'$v'" }
- elsif ( length $v ) { $v = "'$v'" }
- length $v ? $v : ()
- } grep /\S/, split /\R/, $accountcode;
+ ( my $v = $_ ) =~ s/^\s+|\s+$//g; # trim margin whitespace
+ length $v ? dbh->quote($v) : ()
+ } grep /\S/, split /\R/, $accountcode; # collect non-trivial lines
if (@accountcode) {
my $search = 'accountcode IN ( ' . join( ',', @accountcode ) . ' )';
push @qsearch, $search;