summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorivan <ivan>2011-05-09 20:25:57 +0000
committerivan <ivan>2011-05-09 20:25:57 +0000
commitc0e4e71f6e2888fe83c6b288a84dcc4a4897c848 (patch)
tree4023c917e89e465a20f478bc8096ad03a637f38c
parent9531bdfc326d205f18a5d5f05312aa20ba1484bc (diff)
better retry behavior for non-found taqua CDR rewrites, RT#12181
-rw-r--r--FS/bin/freeside-cdrrewrited8
1 files changed, 4 insertions, 4 deletions
diff --git a/FS/bin/freeside-cdrrewrited b/FS/bin/freeside-cdrrewrited
index a365d73db..09a2643e5 100644
--- a/FS/bin/freeside-cdrrewrited
+++ b/FS/bin/freeside-cdrrewrited
@@ -41,12 +41,12 @@ while (1) {
# rewritten "skipped", i.e. why we're a daemon in the first place
# instead of just doing this search like normal CDRs
+ #hmm :/
my @recent = grep { ($accountcode_unmatch{$_} + $accountcode_retry) < time }
keys %accountcode_unmatch;
- #hmm :/
- my $extra_sql = '';
- $extra_sql .= ' AND acctid NOT IN (', join(',', @recent). ') '
- if @recent;
+ my $extra_sql = scalar(@recent)
+ ? ' AND acctid NOT IN (', join(',', @recent). ') '
+ : '';
my $found = 0;
foreach my $cdr (