summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIvan Kohler <ivan@freeside.biz>2017-01-25 13:04:29 -0800
committerIvan Kohler <ivan@freeside.biz>2017-01-25 13:04:29 -0800
commitbaca421d2fa815a6338e9525e3e404928b59235e (patch)
tree53bdfd739dcea578490970f5f8228ea8a2d2c507
parent61bd7e302ca504d1321981a51f389fa01d5a5187 (diff)
better diagnostics for un-pre-rate-able CDRs
-rw-r--r--FS/bin/freeside-cdrrated8
1 files changed, 6 insertions, 2 deletions
diff --git a/FS/bin/freeside-cdrrated b/FS/bin/freeside-cdrrated
index 2966b2e4e..a8fcf5157 100644
--- a/FS/bin/freeside-cdrrated
+++ b/FS/bin/freeside-cdrrated
@@ -82,6 +82,7 @@ while (1) {
my $svc_phone = qsearchs('svc_phone', { 'phonenum' => $number } );
unless ( $svc_phone ) {
#XXX set freesideratestatus or something so we don't keep retrying?
+ warn "no phone number found for CDR ". $cdr->acctid. "\n";
next;
}
@@ -94,7 +95,8 @@ while (1) {
my $cust_pkg = $svc_phone{$number}->cust_svc->cust_pkg;
unless ( $cust_pkg ) {
#XXX unlinked svc_phone?
- # warn and also set freesideratestatus or somesuch?
+ # also set freesideratestatus or somesuch?
+ warn "no package found (unlinked phone number?) for CDR ". $cdr->acctid. "\n";
next;
}
@@ -124,6 +126,7 @@ while (1) {
#XXX no package for this CDR
# warn and also set freesideratestatus or somesuch?
# or at least warn
+ warn "no CDR rating package for CDR ". $cdr->acctid. "\n";
next;
} elsif ( scalar(@part_pkg) > 1 ) {
warn "multiple package could rate CDR ". $cdr->acctid. "\n";
@@ -140,6 +143,7 @@ while (1) {
#then we can't prerate this CDR
#some sort of warning?
# (sucks if you're depending on credit limit fraud warnings)
+ warn "package has min_included; can't prerate CDR ". $cdr->acctid. "\n";
next;
}
@@ -184,7 +188,7 @@ sub _shouldrun {
}
sub usage {
- die "Usage:\n\n freeside-cdrrewrited user\n";
+ die "Usage:\n\n freeside-cdrrated user\n";
}
=head1 NAME