diff options
| author | Mike Robinson <miker@freeside.biz> | 2012-04-30 15:09:19 -0500 |
|---|---|---|
| committer | Mike Robinson <miker@freeside.biz> | 2012-04-30 15:09:19 -0500 |
| commit | adaccb1ca8e3954a7899ef36bb23c05893ebbc81 (patch) | |
| tree | f4b06a35f16d3d7dc60a2a1a25e952d09efcf1d1 | |
| parent | 16be5a799284b89137ec1802129de29f2b262c46 (diff) | |
14919: make indentation and coding match expectations
| -rw-r--r-- | FS/FS/option_Common.pm | 9 | ||||
| -rw-r--r-- | FS/FS/part_export/netsapiens.pm | 16 |
2 files changed, 10 insertions, 15 deletions
diff --git a/FS/FS/option_Common.pm b/FS/FS/option_Common.pm index 40b12cf57..c1dda22af 100644 --- a/FS/FS/option_Common.pm +++ b/FS/FS/option_Common.pm @@ -67,13 +67,8 @@ sub insert { my $error; - $error = $self->check_options($options); - if ( $error ) { - $dbh->rollback if $oldAutoCommit; - return $error; - } - - $error = $self->SUPER::insert; + $error = $self->check_options($options) + || $self->SUPER::insert; if ( $error ) { $dbh->rollback if $oldAutoCommit; return $error; diff --git a/FS/FS/part_export/netsapiens.pm b/FS/FS/part_export/netsapiens.pm index b30951dae..aa89d47a2 100644 --- a/FS/FS/part_export/netsapiens.pm +++ b/FS/FS/part_export/netsapiens.pm @@ -83,16 +83,16 @@ sub rebless { shift; } sub check_options { - my ($self, $options) = @_; + my ($self, $options) = @_; - my $rex = qr/$RE{URI}{HTTP}{-scheme => qr|https?|}/; # match any "http:" or "https:" URL + my $rex = qr/$RE{URI}{HTTP}{-scheme => qr|https?|}/; # match any "http:" or "https:" URL - for my $key (qw/url device_url/) { - if ($$options{$key} && ($$options{$key} !~ $rex)) { - return "Invalid (URL): " . $$options{$key}; - } - } - return ''; + for my $key (qw/url device_url/) { + if ($$options{$key} && ($$options{$key} !~ $rex)) { + return "Invalid (URL): " . $$options{$key}; + } + } + return ''; } |