summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIvan Kohler <ivan@freeside.biz>2014-05-08 02:02:48 -0700
committerJeremy Davis <jeremyd@freeside.biz>2014-05-29 11:34:58 -0400
commita69bdc8db4a3ec643bd19764431aeaf49feadf6c (patch)
treebf8bf37a1abb99fccfa6c58a034bff2c39c52b66
parent7d6818c03f5137848e9459d6943323c21ebdca8b (diff)
fix daily sales/credits/receipts summary vs DST boundaries, RT#26199
-rw-r--r--FS/FS/Report/Table/Daily.pm9
1 files changed, 6 insertions, 3 deletions
diff --git a/FS/FS/Report/Table/Daily.pm b/FS/FS/Report/Table/Daily.pm
index 6087b0dcc..c66801626 100644
--- a/FS/FS/Report/Table/Daily.pm
+++ b/FS/FS/Report/Table/Daily.pm
@@ -4,7 +4,7 @@ use strict;
use vars qw( @ISA );
use FS::Report::Table;
use FS::Conf;
-use Time::Local qw( timelocal );
+use Time::Local qw( timelocal timelocal_nocheck ); # eventually replace with DateTime
use Date::Format qw( time2str );
@ISA = qw( FS::Report::Table );
@@ -66,12 +66,15 @@ sub data {
#warn "daily range $sdate $edate\n";
# XXX: use date_format config for the labels since we have day in the labels now?
- # XXX: leap seconds / DST
while ( $sdate < $edate ) {
push @{$data{label}}, time2str($date_format, $sdate);
my $speriod = $sdate;
- $sdate += 86400;
+
+ #ala part_pkg->add_freq, to deal with local DST. DateTime also a good idea
+ my ($mday,$mon,$year) = (localtime($sdate) )[3,4,5];
+ $sdate = timelocal_nocheck(0,0,0,$mday+1,$mon,$year);
+
my $eperiod = $sdate;
push @{$data{speriod}}, $speriod;