summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristopher Burger <burgerc@freeside.biz>2017-11-28 20:17:28 -0500
committerChristopher Burger <burgerc@freeside.biz>2017-12-12 11:21:54 -0500
commit72210c8579e5d5ffeb3127afb1d35236417aa469 (patch)
treeb79e8bb5b72b0bbb9138608d77fe003843b5c14c
parent020e2df25391da9028dfbd9962b554ac20f54f38 (diff)
Revert "RT# 24643 - fixed error in saving waive setup fee flag when not selected"
This reverts commit 7e2111f1ebc063df6a0afbb5903ae17a96ca3bb8.
-rw-r--r--FS/FS/cust_pkg.pm3
-rw-r--r--httemplate/edit/process/change-cust_pkg.html2
2 files changed, 1 insertions, 4 deletions
diff --git a/FS/FS/cust_pkg.pm b/FS/FS/cust_pkg.pm
index b2cc874a4..c95d31b4d 100644
--- a/FS/FS/cust_pkg.pm
+++ b/FS/FS/cust_pkg.pm
@@ -2363,8 +2363,7 @@ sub change {
$same_pkgpart = 0;
}
- if ($opt->{'waive_setup'}) { $self->set('waive_setup', $opt->{'waive_setup'}) }
- else { $self->set('waive_setup', ''); }
+ $self->set('waive_setup', $opt->{'waive_setup'}) if $opt->{'waive_setup'};
# Before going any further here: if the package is still in the pre-setup
# state, it's safe to modify it in place. No need to charge/credit for
diff --git a/httemplate/edit/process/change-cust_pkg.html b/httemplate/edit/process/change-cust_pkg.html
index 0e87ad859..3d50a134e 100644
--- a/httemplate/edit/process/change-cust_pkg.html
+++ b/httemplate/edit/process/change-cust_pkg.html
@@ -40,8 +40,6 @@ if ( $cgi->param('locationnum') == -1 ) {
$change{'cust_location'} = $cust_location;
}
-$change{waive_setup} = '';
-
if ( $cgi->param('setup_discountnum') =~ /^(-?\d+)$/ ) {
if ( $1 == -2 ) {
$change{waive_setup} = 'Y';