diff options
| author | Ivan Kohler <ivan@freeside.biz> | 2014-11-18 11:41:28 -0800 |
|---|---|---|
| committer | Ivan Kohler <ivan@freeside.biz> | 2014-11-18 11:41:57 -0800 |
| commit | 658ee9ec1d60d184d94e8edb9aeec57be809ebbe (patch) | |
| tree | 6d108980a108c6bf5dcb23c0d83e6934ef1c2467 | |
| parent | 248cd0afdf088d4b79a6afea4d288d58c5b96400 (diff) | |
optimize history search (invoice rending time for svc_ records with tons of changes), RT#32190
| -rw-r--r-- | FS/FS/h_Common.pm | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/FS/FS/h_Common.pm b/FS/FS/h_Common.pm index 9b5ad09d9..87fb76da2 100644 --- a/FS/FS/h_Common.pm +++ b/FS/FS/h_Common.pm @@ -52,19 +52,19 @@ sub sql_h_search { my( $notdeleted, $notdeleted_mr ) = ( '', '' ); if ( scalar(@_) && $_[0] ) { $notdeleted = - "AND 0 = ( SELECT COUNT(*) FROM $table as notdel - WHERE notdel.$pkey = maintable.$pkey - AND notdel.history_action = 'delete' - AND notdel.history_date > maintable.history_date - AND notdel.history_date <= $_[0] - )"; + "AND NOT EXISTS ( SELECT 1 FROM $table as notdel + WHERE notdel.$pkey = maintable.$pkey + AND notdel.history_action = 'delete' + AND notdel.history_date > maintable.history_date + AND notdel.history_date <= $_[0] + )"; $notdeleted_mr = - "AND 0 = ( SELECT COUNT(*) FROM $table as notdel_mr - WHERE notdel_mr.$pkey = mostrecent.$pkey - AND notdel_mr.history_action = 'delete' - AND notdel_mr.history_date > mostrecent.history_date - AND notdel_mr.history_date <= $_[0] - )"; + "AND NOT EXISTS ( SELECT 1 FROM $table as notdel_mr + WHERE notdel_mr.$pkey = mostrecent.$pkey + AND notdel_mr.history_action = 'delete' + AND notdel_mr.history_date > mostrecent.history_date + AND notdel_mr.history_date <= $_[0] + )"; } ( |