RT# 76312 - improved code by using an array datatype rather than a string that is then later manipulated.

1 files changed, 5 insertions, 7 deletions

diff --git a/httemplate/search/elements/cust_pay_or_refund.html b/httemplate/search/elements/cust_pay_or_refund.html
index 6bd3db622..187fc8357 100755
--- a/httemplate/search/elements/cust_pay_or_refund.html
+++ b/httemplate/search/elements/cust_pay_or_refund.html
@@ -463,17 +463,15 @@ if ( $cgi->param('magic') ) {
   }
 
   #check for customer tags
-  my $tagcount;
-  my $tags;
+  my @tags;
   foreach my $p (keys $cgi->Vars) {
     if ($p =~ /^tagnum(\d+)/ && $1) {
-      $tagcount++;
-      $addl_from .= " LEFT JOIN cust_tag ON (cust_tag.custnum = cust_pay.custnum)" unless $tagcount > 1;
-      $tags .= "$1,";
+      $addl_from .= " LEFT JOIN cust_tag ON (cust_tag.custnum = cust_pay.custnum)" unless @tags;
+      push @tags, $1;
     }
   }
-  if ($tags) {
-    $tags =~ s/,$//;
+  if (@tags) {
+    my $tags = join(',',@tags);
     push @search, "cust_tag.tagnum in ($tags)";
   }