diff options
| author | C.J. Adams-Collier <cjac@colliertech.org> | 2014-09-03 15:24:58 -0700 |
|---|---|---|
| committer | C.J. Adams-Collier <cjac@colliertech.org> | 2014-09-03 15:26:03 -0700 |
| commit | 5f5fbed30812124e5865c4aaf20c927f7d2d01bd (patch) | |
| tree | a4ba08d09a545ccded871052dedf6c40db1ff164 | |
| parent | 2f16e6d6e40950637f714d2fdebfd44db1cf8db7 (diff) | |
FS RT #884 code review recommendations per mwells
| -rw-r--r-- | httemplate/elements/menu.html | 4 | ||||
| -rw-r--r-- | httemplate/graph/signupdate.cgi | 4 |
2 files changed, 3 insertions, 5 deletions
diff --git a/httemplate/elements/menu.html b/httemplate/elements/menu.html index 580c8dea1..d34904592 100644 --- a/httemplate/elements/menu.html +++ b/httemplate/elements/menu.html @@ -113,8 +113,8 @@ tie my %report_customers, 'Tie::IxHash'; $report_customers{'List customers'} = [ \%report_customers_lists, 'List customers' ] if $curuser->access_right('List all customers'); $report_customers{'Zip code distribution'} = [ $fsurl. 'search/report_cust_main-zip.html', 'Zip codes by number of customers' ]; -$report_customers{'Customer signup report'} = [ $fsurl. 'graph/report_cust_signup.html', 'New customer signups by date' ], -$report_customers{'Sign-up Date report'} = [ $fsurl. 'graph/report_signupdate.html', 'Sign-up Date report (by date of sign-up)' ]; +$report_customers{'Customer signup report'} = [ $fsurl. 'graph/report_cust_signup.html', 'New customer signups by date' ]; +$report_customers{'Signup date report'} = [ $fsurl. 'graph/report_signupdate.html', 'Signup date report (by date of signup)' ]; $report_customers{'Advanced customer reports'} = [ $fsurl. 'search/report_cust_main.html', 'by status, signup date, agent, etc.' ] if $curuser->access_right('Advanced customer search'); diff --git a/httemplate/graph/signupdate.cgi b/httemplate/graph/signupdate.cgi index 43deddc8d..23e459664 100644 --- a/httemplate/graph/signupdate.cgi +++ b/httemplate/graph/signupdate.cgi @@ -36,13 +36,11 @@ $where{'usernum'} = $usernum if $usernum; my $sdate = DateTime->new( year => $cgi->param('start_year'), month => $cgi->param('start_month'), - time_zone => 'America/Los_Angeles', )->epoch(); my $edate = DateTime->new( year => $cgi->param('end_year'), - month => $cgi->param('end_month'), - time_zone => 'America/Los_Angeles', + month => ($cgi->param('end_month') % 12 + 1) # first day of the next month )->epoch(); my $where .= " AND signupdate >= $sdate ". |