diff options
author | Mark Wells <mark@freeside.biz> | 2014-06-13 12:48:02 -0700 |
---|---|---|
committer | Mark Wells <mark@freeside.biz> | 2014-06-13 12:48:02 -0700 |
commit | 4ee96719dd1665ef3694aa983cc9046b53e8cc5d (patch) | |
tree | da734d1729187d48b9773802fb4575440def1394 | |
parent | f1e4e2c83b33a2c6280073ced388a91742a3bb46 (diff) |
but don't break Pg cursors in the process, #28895
-rw-r--r-- | FS/FS/Cursor.pm | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/FS/FS/Cursor.pm b/FS/FS/Cursor.pm index 3af3c1bff..f6d8816a7 100644 --- a/FS/FS/Cursor.pm +++ b/FS/FS/Cursor.pm @@ -77,13 +77,13 @@ sub new { } $sth->execute or die $sth->errstr; - # in mysql, make sure we're not holding any locks on the tables mentioned - # in the query; in Pg this will do nothing. - $dbh->commit; if ( driver_name() eq 'Pg' ) { $self->{fetch} = $dbh->prepare("FETCH FORWARD $buffer FROM ".$self->{id}); } elsif ( driver_name() eq 'mysql' ) { + # make sure we're not holding any locks on the tables mentioned + # in the query + $dbh->commit if driver_name() eq 'mysql'; $self->{fetch} = $dbh->prepare("SELECT * FROM $self->{id} ORDER BY rownum LIMIT ?, $buffer"); } |