summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMark Wells <mark@freeside.biz>2015-03-10 12:38:57 -0700
committerMark Wells <mark@freeside.biz>2015-03-10 12:38:57 -0700
commit4d81504d903cc11cc3637ecc3e6f4af44c59addd (patch)
tree1cb01899d997a07bf45f22c1430a65ea0aadaaa2
parent3244e4dcb9d88c728f3bfa1294b3f78cb7a96a20 (diff)
set a default location for quotation_pkg records, #32340
-rw-r--r--FS/FS/Upgrade.pm3
-rw-r--r--FS/FS/quotation_pkg.pm28
2 files changed, 31 insertions, 0 deletions
diff --git a/FS/FS/Upgrade.pm b/FS/FS/Upgrade.pm
index 314622288..3694f8a51 100644
--- a/FS/FS/Upgrade.pm
+++ b/FS/FS/Upgrade.pm
@@ -406,6 +406,9 @@ sub upgrade_data {
#populate state FIPS codes if not already done
'state' => [],
+
+ #set default locations on quoted packages
+ 'quotation_pkg' => [],
;
\%hash;
diff --git a/FS/FS/quotation_pkg.pm b/FS/FS/quotation_pkg.pm
index 107b27188..342e9bb9c 100644
--- a/FS/FS/quotation_pkg.pm
+++ b/FS/FS/quotation_pkg.pm
@@ -195,6 +195,16 @@ sub check {
|| $self->ut_enum('waive_setup', [ '', 'Y'] )
;
+ if ($self->locationnum eq '') {
+ # use the customer default
+ my $quotation = $self->quotation;
+ if ($quotation->custnum) {
+ $self->set('locationnum', $quotation->cust_main->ship_locationnum);
+ } elsif ($quotation->prospectnum) {
+ $self->set('locationnum', $quotation->prospect_main->locationnum);
+ } # else the quotation is invalid
+ }
+
return $error if $error;
$self->SUPER::check;
@@ -444,6 +454,24 @@ sub cust_location {
$self->locationnum ? qsearchs('cust_location', { locationnum => $self->locationnum }) : '';
}
+
+sub _upgrade_data {
+ my $class = shift;
+ my @quotation_pkg_without_location =
+ qsearch( 'quotation_pkg', { locationnum => '' } );
+ if (@quotation_pkg_without_location) {
+ warn "setting default location on quotation_pkg records\n";
+ foreach my $quotation_pkg (@quotation_pkg_without_location) {
+ # check() will fix this
+ my $error = $quotation_pkg->replace;
+ if ($error) {
+ die "quotation #".$quotation_pkg->quotationnum.": $error\n";
+ }
+ }
+ }
+ '';
+}
+
=back
=head1 BUGS