diff options
| author | Mark Wells <mark@freeside.biz> | 2012-04-27 14:25:58 -0700 |
|---|---|---|
| committer | Mark Wells <mark@freeside.biz> | 2012-04-27 14:25:58 -0700 |
| commit | 141c6ddb6daccb5546e35ba98131a30c4a64ee1d (patch) | |
| tree | 89e516c7f9b12bb1980126274c63e8483872e928 | |
| parent | 8898d63f1a0be81775ecef61094d62129ea6ff38 (diff) | |
fix some warnings in ticket escalation, #17417
| -rw-r--r-- | rt/lib/RT/Action/Accumulate.pm | 3 | ||||
| -rwxr-xr-x | rt/lib/RT/Action/EscalateQueue.pm | 21 |
2 files changed, 14 insertions, 10 deletions
diff --git a/rt/lib/RT/Action/Accumulate.pm b/rt/lib/RT/Action/Accumulate.pm index c4ca667ea..14675b894 100644 --- a/rt/lib/RT/Action/Accumulate.pm +++ b/rt/lib/RT/Action/Accumulate.pm @@ -23,7 +23,8 @@ the same name, and should be single-valued fields. sub Prepare { my $self = shift; my $cfname = $self->Argument or return 0; - $self->{'inc_by'} = $self->TransactionObj->FirstCustomFieldValue($cfname); + $self->{'inc_by'} = $self->TransactionObj->FirstCustomFieldValue($cfname) + || ''; return ( $self->{'inc_by'} =~ /^(\d+)$/ ); } diff --git a/rt/lib/RT/Action/EscalateQueue.pm b/rt/lib/RT/Action/EscalateQueue.pm index adafbdfb7..2775a8384 100755 --- a/rt/lib/RT/Action/EscalateQueue.pm +++ b/rt/lib/RT/Action/EscalateQueue.pm @@ -116,15 +116,18 @@ sub Commit { if ( my $due_in = $new_queue->DefaultDueIn ) { $Due->SetToNow; $Due->AddDays( $due_in ); - } - ( $val, $msg ) = $ticket->_Set( - Field => 'Due', - Value => $Due->ISO, - RecordTransaction => 0, - ); - if (! $val) { - $RT::Logger->error( "Couldn't set new due date: $msg" ); - return (0, $msg); + + if ( $Due->ISO ne $ticket->Due ) { + ( $val, $msg ) = $ticket->_Set( + Field => 'Due', + Value => $Due->ISO, + RecordTransaction => 0, + ); + if (! $val) { + $RT::Logger->error( "Couldn't set new due date: $msg" ); + return (0, $msg); + } + } } return 1; } |
