diff options
| author | Ivan Kohler <ivan@freeside.biz> | 2014-01-15 22:15:42 -0800 |
|---|---|---|
| committer | Ivan Kohler <ivan@freeside.biz> | 2014-01-15 22:15:42 -0800 |
| commit | 02a6274b9eec3668afe0835df2009790f010a0b9 (patch) | |
| tree | f7267891e5cec8b6dc41f8b8f0c5409d22d81475 | |
| parent | ded7dddeaf4ec7ec42b5f59133b487a62f43ea78 (diff) | |
fix part_pkg.comment showing in signup and self-service package order, RT#25557
| -rw-r--r-- | FS/FS/ClientAPI/MasonComponent.pm | 1 | ||||
| -rw-r--r-- | FS/FS/part_pkg.pm | 5 | ||||
| -rw-r--r-- | httemplate/edit/cust_main/first_pkg/select-part_pkg.html | 3 |
3 files changed, 8 insertions, 1 deletions
diff --git a/FS/FS/ClientAPI/MasonComponent.pm b/FS/FS/ClientAPI/MasonComponent.pm index c4094ffe0..8a31185bd 100644 --- a/FS/FS/ClientAPI/MasonComponent.pm +++ b/FS/FS/ClientAPI/MasonComponent.pm @@ -99,6 +99,7 @@ my %session_callbacks = ( my %args = @$argsref; $args{part_pkg} = \@part_pkg; $args{first_svc} = \@first_svc; + $args{no_comment} = 1; @$argsref = ( %args ); return ''; #no error diff --git a/FS/FS/part_pkg.pm b/FS/FS/part_pkg.pm index 2cccce051..c908c917e 100644 --- a/FS/FS/part_pkg.pm +++ b/FS/FS/part_pkg.pm @@ -784,6 +784,11 @@ sub custom_comment { $price_info; } +sub pkg_price_info { + my $self = shift; + $self->pkg. ' - '. ($self->price_info || 'No charge'); +} + =item pkg_class Returns the package class, as an FS::pkg_class object, or the empty string diff --git a/httemplate/edit/cust_main/first_pkg/select-part_pkg.html b/httemplate/edit/cust_main/first_pkg/select-part_pkg.html index 709a8ad6c..3c2eac018 100644 --- a/httemplate/edit/cust_main/first_pkg/select-part_pkg.html +++ b/httemplate/edit/cust_main/first_pkg/select-part_pkg.html @@ -144,8 +144,9 @@ foreach my $part_pkg ( @part_pkg ) { my @options = (); push @options, '' unless $opt{'disable_empty'}; push @options, map $pkgpart_svcpart{ $_->pkgpart }, @part_pkg; +my $label_method = $opt{no_comment} ? 'pkg_price_info' : 'pkg_comment' ; my %labels = ( '' => ( $opt{'empty_label'} || '(none)' ), - map { $pkgpart_svcpart{ $_->pkgpart } => $_->pkg_comment } + map { $pkgpart_svcpart{ $_->pkgpart } => $_->$label_method() } @part_pkg ); |