- Update for new test account.

- Add "cargs" argument including "-k" when in test mode.
- Move tests from t2/ and have them actually work out of the box.
- get rid of old Exporter / AutoLoader cruft
- patch from Mark D. Anderson <mda@discerning.com>:
  - addrnum should be first digit string, not first word
  - avoid uninitialized variable warnings in lpperl due to webspace and
    debug
  - Map customer_ip, customer_id, invoice_number and description fields
  - Pass email, company, fax fields
  - Set lpperl debug if our $DEBUG is set
  - Better/supplimental download link for lpperl.pm

1 files changed, 34 insertions, 19 deletions

diff --git a/LinkPoint.pm b/LinkPoint.pm
index 84ea74e..70b6253 100644
--- a/LinkPoint.pm
+++ b/LinkPoint.pm
@@ -1,18 +1,11 @@
 package Business::OnlinePayment::LinkPoint;
 
-# $Id: LinkPoint.pm,v 1.28 2007-05-01 21:37:17 jeff Exp $
-
 use strict;
 use vars qw($VERSION @ISA $DEBUG @EXPORT @EXPORT_OK);
 use Carp qw(croak);
-use AutoLoader;
 use Business::OnlinePayment;
 
-require Exporter;
-
-@ISA = qw(Exporter AutoLoader Business::OnlinePayment);
-@EXPORT = qw();
-@EXPORT_OK = qw();
+@ISA = qw(Business::OnlinePayment);
 $VERSION = '0.08';
 $DEBUG = 0;
 
@@ -130,7 +123,7 @@ sub submit {
       $month = '0'. $month if $month =~ /^\d$/;
     }
 
-    $content{'address'} =~ /^(\S+)\s/;
+    $content{'address'} =~ /^(\d+)\s/;
     my $addrnum = $1;
 
     my $result = $content{'result'};
@@ -152,13 +145,21 @@ sub submit {
       #storename    => \( $self->storename ),
       configfile   => \( $self->storename ),
       keyfile      => \( $self->keyfile ),
-      addrnum      => \$addrnum,
+
+      chargetotal  => 'amount',
       result       => \$result,
+      addrnum      => \$addrnum,
+      oid          => 'order_number',
+      ip           => 'customer_ip',
+      userid       => 'customer_id',
+      ponumber     => 'invoice_number',
+      comments     => 'description',
+      #reference_number => 'reference_number',
+
       cardnumber   => 'card_number',
       cardexpmonth => \$month,
       cardexpyear  => \$year,
-      chargetotal  => 'amount',
-      oid          => 'order_number',
+
       bankname     => 'bank_name',
       bankstate    => 'bank_state',
       routing      => 'routing_code',
@@ -185,7 +186,7 @@ sub submit {
       host port configfile keyfile
       result
       chargetotal cardnumber cardexpmonth cardexpyear
-      name email phone addrnum city state zip country
+      name company email phone fax addrnum city state zip country
       oid
       dl dlstate routing account accounttype bankname bankstate name void
 
@@ -200,14 +201,20 @@ sub submit {
 
     if ( $DEBUG ) {
       warn "$_ => $post_data{$_}\n" foreach keys %post_data;
+      $post_data{debug} = 'true';
     }
 
-    my %response;
+    $post_data{'cargs'} = '-k -m 300 -s -S' if $self->test_transaction;
+
+    # avoid some uninitialized warnings in lpperl.pm
+    foreach (qw(webspace debug debugging)) { $post_data{$_} ||= '' }
+
+    #my %response;
     #{
     #  local($^W)=0;
     #  %response = $lperl->$action(\%post_data);
     #}
-    %response = $lperl->curl_process(\%post_data);
+    my %response = $lperl->curl_process(\%post_data);
 
     if ( $DEBUG ) {
       warn "$_ => $response{$_}\n" for keys %response;
@@ -222,9 +229,11 @@ sub submit {
     } else {
       $self->is_success(0);
       $self->result_code('');
-      $response{'r_error'} =~/\S/
-        ? $self->error_message($response{'r_error'})
-        : $self->error_message($response{'r_approved'}); # no r_error for checks
+      if ( $response{'r_error'} =~ /\S/ ) {
+        $self->error_message($response{'r_error'});
+      } else {
+        $self->error_message($response{'r_approved'}); # no r_error for checks
+      }
     }
 
 }
@@ -279,8 +288,10 @@ For detailed information see L<Business::OnlinePayment>.
 
 =head1 COMPATIBILITY
 
-This module implements an interface to the LinkPoint Perl Wrapper
+This module implements an interface to the LinkPoint Perl Wrapper "lpperl",
+which you need to download and install separately.
 http://www.linkpoint.com/product_solutions/internet/lperl/lperl_main.html
+http://www.linkpoint.com/viewcart/down_index.htm
 
 Versions 0.4 and on of this module support the LinkPoint Perl Wrapper version
 3.5.
@@ -291,6 +302,10 @@ Versions 0.4 and on of this module support the LinkPoint Perl Wrapper version
 
 Ivan Kohler <ivan-linkpoint@420.am>
 
+Contributions from Mark D. Anderson <mda@discerning.com>
+
+Echeck work by Jeff Finucane <jeff@cmh.net>
+
 Based on Busienss::OnlinePayment::AuthorizeNet written by Jason Kohles.
 
 =head1 SEE ALSO