summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorfbriere <fbriere>2006-02-17 23:44:14 +0000
committerfbriere <fbriere>2006-02-17 23:44:14 +0000
commite7b48d8f859ab09851ef35ba4cd19d61fbe66f1f (patch)
tree28b0bb554726d7796a3c74e64ff66658c60612e0
parente073ba9f3ec63298790683c9e0b8b20b8cd40417 (diff)
Delete error_message() if transaction was successful
-rwxr-xr-xInternetSecure.pm9
-rwxr-xr-xt/30parse.t2
2 files changed, 7 insertions, 4 deletions
diff --git a/InternetSecure.pm b/InternetSecure.pm
index e3a21e5..f2811ab 100755
--- a/InternetSecure.pm
+++ b/InternetSecure.pm
@@ -260,6 +260,9 @@ sub parse_response {
# Completely undocumented field that sometimes override <Verbiage>
$self->error_message($response->{Error}) if $response->{Error};
+
+ # Delete error_message if transaction was successful
+ $self->error_message(undef) if $self->is_success;
$self->card_type(CARD_TYPES->{$self->card_type});
@@ -469,9 +472,9 @@ Response code returned by InternetSecure.
=item error_message()
-Text description of the response code. (Do not rely on this to check for
-errors, as a description will also be returned for successful transactions.
-Use B<is_success>() instead.)
+Error message if the transaction was unsuccessful; C<undef> otherwise. (You
+should not rely on this to test whether a transaction was successful; use
+B<is_success>() instead.)
=item receipt_number()
diff --git a/t/30parse.t b/t/30parse.t
index f5bb267..7e8e678 100755
--- a/t/30parse.t
+++ b/t/30parse.t
@@ -14,7 +14,7 @@ use constant RESULTS => (
is_success => 1,
result_code => '2000',
authorization => 'T00000',
- error_message => 'Test Approved',
+ error_message => undef,
receipt_number => '1096019995.5012',
sales_number => 0,
date => '2003/12/17 09:59:58',