From e1215a3e22ce14f9a73b15c6ed24fdce11f928a9 Mon Sep 17 00:00:00 2001 From: Mark Wells Date: Fri, 22 Apr 2016 10:21:22 -0700 Subject: [PATCH] fix apportionment of flat fees on zero-charge invoices, #39816 --- FS/FS/part_fee.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/FS/FS/part_fee.pm b/FS/FS/part_fee.pm index 0ca52a096..1d4682c1e 100644 --- a/FS/FS/part_fee.pm +++ b/FS/FS/part_fee.pm @@ -402,7 +402,8 @@ sub lineitem { # if this is a percentage fee and has line item fractions, # adjust them to be proportional and to add up correctly. - if ( @item_base ) { + # don't try this if we're charging on a zero-amount set of line items. + if ( scalar(@item_base) > 0 and $total_base > 0 ) { my $cents = $amount * 100; # not necessarily the same as percent my $multiplier = $amount / $total_base; -- 2.11.0