From d54644e17fc84f3853ca020ae68605e7900855fb Mon Sep 17 00:00:00 2001 From: "C.J. Adams-Collier" Date: Thu, 18 Sep 2014 11:35:38 -0700 Subject: [PATCH] including error message, and moving session_id reset outside of the conditional block --- fs_selfservice/FS-SelfService/cgi/selfservice.cgi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs_selfservice/FS-SelfService/cgi/selfservice.cgi b/fs_selfservice/FS-SelfService/cgi/selfservice.cgi index 5c0190f96..0226d1183 100755 --- a/fs_selfservice/FS-SelfService/cgi/selfservice.cgi +++ b/fs_selfservice/FS-SelfService/cgi/selfservice.cgi @@ -124,14 +124,16 @@ unless ( $nologin_actions{$action} ) { 'email' => $email, 'password' => $password ); + if ( $login_rv->{'error'} ) { my $ip = $cgi->remote_addr(); - warn("login failure [email $email] [ip $ip]"); + warn("login failure [email $email] [ip $ip] [error $login_rv->{error}]"); } else { #successful login - $session_id = $login_rv->{'session_id'}; } + $session_id = $login_rv->{'session_id'}; + } else { $cgi->param('username') =~ /^\s*([a-z0-9_\-\.\&]{0,$form_max})\s*$/i; -- 2.11.0