From d51c41b94bfa87d6c779ac666495151bf6fc3913 Mon Sep 17 00:00:00 2001 From: ivan Date: Wed, 30 Dec 1998 23:03:34 +0000 Subject: [PATCH] bugfixes; fields isn't exported by derived classes --- TODO | 5 +++-- htdocs/browse/part_svc.cgi | 11 +++++++---- htdocs/edit/part_svc.cgi | 11 +++++++---- htdocs/edit/process/agent.cgi | 11 +++++++---- htdocs/edit/process/agent_type.cgi | 11 +++++++---- htdocs/edit/process/cust_pay.cgi | 9 ++++++--- htdocs/edit/process/part_pkg.cgi | 11 +++++++---- htdocs/edit/process/part_referral.cgi | 11 +++++++---- htdocs/edit/process/part_svc.cgi | 11 +++++++---- htdocs/edit/process/svc_acct_pop.cgi | 11 +++++++---- htdocs/edit/svc_acct.cgi | 11 +++++++---- htdocs/edit/svc_acct_sm.cgi | 11 +++++++---- htdocs/edit/svc_domain.cgi | 11 +++++++---- htdocs/view/cust_bill.cgi | 9 ++++++--- htdocs/view/cust_main.cgi | 11 +++++++---- 15 files changed, 99 insertions(+), 56 deletions(-) diff --git a/TODO b/TODO index 5c8e02cef..349b2bf12 100644 --- a/TODO +++ b/TODO @@ -1,4 +1,4 @@ -$Id: TODO,v 1.17 1998-12-29 11:59:32 ivan Exp $ +$Id: TODO,v 1.18 1998-12-30 23:03:19 ivan Exp $ If you are interested in helping with any of these, please join the mailing list (send a blank message to ivan-freeside-subscribe@sisd.com) to avoid @@ -6,7 +6,8 @@ duplication of effort. -- 1.1.x -- -check all .pm's for numeric comparisons done as `eq' +check all .pm's for numeric comparisons done as `eq' - works fine now because +only used with integers that aren't space-padded. FS::cust_pkg _require_'s FS::$svc, but this won't work with %FS::UID::callback loading of configuration. (pry need same idea, but will run immediately if diff --git a/htdocs/browse/part_svc.cgi b/htdocs/browse/part_svc.cgi index 983849f69..93864a422 100755 --- a/htdocs/browse/part_svc.cgi +++ b/htdocs/browse/part_svc.cgi @@ -1,6 +1,6 @@ #!/usr/bin/perl -Tw # -# $Id: part_svc.cgi,v 1.5 1998-12-17 05:25:21 ivan Exp $ +# $Id: part_svc.cgi,v 1.6 1998-12-30 23:03:20 ivan Exp $ # # ivan@sisd.com 97-nov-14, 97-dec-9 # @@ -10,7 +10,10 @@ # lose background, FS::CGI ivan@sisd.com 98-sep-2 # # $Log: part_svc.cgi,v $ -# Revision 1.5 1998-12-17 05:25:21 ivan +# Revision 1.6 1998-12-30 23:03:20 ivan +# bugfixes; fields isn't exported by derived classes +# +# Revision 1.5 1998/12/17 05:25:21 ivan # fix visual and other bugs # # Revision 1.4 1998/11/21 02:26:22 ivan @@ -27,8 +30,8 @@ use strict; use CGI; use CGI::Carp qw(fatalsToBrowser); use FS::UID qw(cgisuidsetup); -use FS::Record qw(qsearch); -use FS::part_svc qw(fields); +use FS::Record qw(qsearch fields); +use FS::part_svc); use FS::CGI qw(header menubar popurl table); my($cgi) = new CGI; diff --git a/htdocs/edit/part_svc.cgi b/htdocs/edit/part_svc.cgi index 6fbe19428..9baaabfe0 100755 --- a/htdocs/edit/part_svc.cgi +++ b/htdocs/edit/part_svc.cgi @@ -1,6 +1,6 @@ #!/usr/bin/perl -Tw # -# $Id: part_svc.cgi,v 1.4 1998-12-17 06:17:07 ivan Exp $ +# $Id: part_svc.cgi,v 1.5 1998-12-30 23:03:21 ivan Exp $ # # ivan@sisd.com 97-nov-14 # @@ -10,7 +10,10 @@ # use FS::CGI, added inline documentation ivan@sisd.com 98-jul-12 # # $Log: part_svc.cgi,v $ -# Revision 1.4 1998-12-17 06:17:07 ivan +# Revision 1.5 1998-12-30 23:03:21 ivan +# bugfixes; fields isn't exported by derived classes +# +# Revision 1.4 1998/12/17 06:17:07 ivan # fix double // in relative URLs, s/CGI::Base/CGI/; # # Revision 1.3 1998/11/21 06:43:26 ivan @@ -21,8 +24,8 @@ use strict; use CGI; use CGI::Carp qw(fatalsToBrowser); use FS::UID qw(cgisuidsetup); -use FS::Record qw(qsearchs); -use FS::part_svc qw(fields); +use FS::Record qw(qsearchs fields); +use FS::part_svc; use FS::CGI qw(header menubar popurl table); my($cgi) = new CGI; diff --git a/htdocs/edit/process/agent.cgi b/htdocs/edit/process/agent.cgi index 1bb5bbaae..b8f818675 100755 --- a/htdocs/edit/process/agent.cgi +++ b/htdocs/edit/process/agent.cgi @@ -1,6 +1,6 @@ #!/usr/bin/perl -Tw # -# $Id: agent.cgi,v 1.3 1998-12-17 08:40:16 ivan Exp $ +# $Id: agent.cgi,v 1.4 1998-12-30 23:03:26 ivan Exp $ # # ivan@sisd.com 97-dec-12 # @@ -10,7 +10,10 @@ # lose background, FS::CGI ivan@sisd.com 98-sep-2 # # $Log: agent.cgi,v $ -# Revision 1.3 1998-12-17 08:40:16 ivan +# Revision 1.4 1998-12-30 23:03:26 ivan +# bugfixes; fields isn't exported by derived classes +# +# Revision 1.3 1998/12/17 08:40:16 ivan # s/CGI::Request/CGI.pm/; etc # # Revision 1.2 1998/11/23 07:52:29 ivan @@ -21,8 +24,8 @@ use strict; use CGI; use CGI::Carp qw(fatalsToBrowser); use FS::UID qw(cgisuidsetup); -use FS::Record qw(qsearch qsearchs); -use FS::agent qw(fields); +use FS::Record qw(qsearch qsearchs fields); +use FS::agent; use FS::CGI qw(idiot popurl); my($cgi)=new CGI; diff --git a/htdocs/edit/process/agent_type.cgi b/htdocs/edit/process/agent_type.cgi index c6f607d42..c796dd66d 100755 --- a/htdocs/edit/process/agent_type.cgi +++ b/htdocs/edit/process/agent_type.cgi @@ -1,6 +1,6 @@ #!/usr/bin/perl -Tw # -# $Id: agent_type.cgi,v 1.3 1998-12-17 08:40:17 ivan Exp $ +# $Id: agent_type.cgi,v 1.4 1998-12-30 23:03:27 ivan Exp $ # # ivan@sisd.com 97-dec-11 # @@ -10,7 +10,10 @@ # lose background, FS::CGI ivan@sisd.com 98-sep-2 # # $Log: agent_type.cgi,v $ -# Revision 1.3 1998-12-17 08:40:17 ivan +# Revision 1.4 1998-12-30 23:03:27 ivan +# bugfixes; fields isn't exported by derived classes +# +# Revision 1.3 1998/12/17 08:40:17 ivan # s/CGI::Request/CGI.pm/; etc # # Revision 1.2 1998/11/21 07:49:20 ivan @@ -22,8 +25,8 @@ use CGI; use CGI::Carp qw(fatalsToBrowser); use FS::CGI qw(idiot popurl); use FS::UID qw(cgisuidsetup); -use FS::Record qw(qsearch qsearchs); -use FS::agent_type qw(fields); +use FS::Record qw(qsearch qsearchs fields); +use FS::agent_type; use FS::type_pkgs; use FS::part_pkg; diff --git a/htdocs/edit/process/cust_pay.cgi b/htdocs/edit/process/cust_pay.cgi index 619a93a2a..ce7929a77 100755 --- a/htdocs/edit/process/cust_pay.cgi +++ b/htdocs/edit/process/cust_pay.cgi @@ -1,6 +1,6 @@ #!/usr/bin/perl -Tw # -# $Id: cust_pay.cgi,v 1.2 1998-12-17 08:40:22 ivan Exp $ +# $Id: cust_pay.cgi,v 1.3 1998-12-30 23:03:28 ivan Exp $ # # Usage: post form to: # http://server.name/path/cust_pay.cgi @@ -15,7 +15,10 @@ # bmccane@maxbaud.net 98-apr-3 # # $Log: cust_pay.cgi,v $ -# Revision 1.2 1998-12-17 08:40:22 ivan +# Revision 1.3 1998-12-30 23:03:28 ivan +# bugfixes; fields isn't exported by derived classes +# +# Revision 1.2 1998/12/17 08:40:22 ivan # s/CGI::Request/CGI.pm/; etc # @@ -24,7 +27,7 @@ use CGI; use CGI::Carp qw(fatalsToBrowser); use FS::UID qw(cgisuidsetup); use FS::CGI qw(idiot popurl); -use FS::cust_pay qw(fields); +use FS::cust_pay; my($cgi)=new CGI; &cgisuidsetup($cgi); diff --git a/htdocs/edit/process/part_pkg.cgi b/htdocs/edit/process/part_pkg.cgi index dca8f1374..d1f023df9 100755 --- a/htdocs/edit/process/part_pkg.cgi +++ b/htdocs/edit/process/part_pkg.cgi @@ -1,6 +1,6 @@ #!/usr/bin/perl -Tw # -# $Id: part_pkg.cgi,v 1.4 1998-12-17 08:40:24 ivan Exp $ +# $Id: part_pkg.cgi,v 1.5 1998-12-30 23:03:29 ivan Exp $ # # process/part_pkg.cgi: Edit package definitions (process form) # @@ -17,7 +17,10 @@ # lose background, FS::CGI ivan@sisd.com 98-sep-2 # # $Log: part_pkg.cgi,v $ -# Revision 1.4 1998-12-17 08:40:24 ivan +# Revision 1.5 1998-12-30 23:03:29 ivan +# bugfixes; fields isn't exported by derived classes +# +# Revision 1.4 1998/12/17 08:40:24 ivan # s/CGI::Request/CGI.pm/; etc # # Revision 1.3 1998/11/21 07:17:58 ivan @@ -32,8 +35,8 @@ use CGI; use CGI::Carp qw(fatalsToBrowser); use FS::UID qw(cgisuidsetup); use FS::CGI qw(eidiot popurl); -use FS::Record qw(qsearch qsearchs); -use FS::part_pkg qw(fields); +use FS::Record qw(qsearch qsearchs fields); +use FS::part_pkg; use FS::pkg_svc; use FS::cust_pkg; diff --git a/htdocs/edit/process/part_referral.cgi b/htdocs/edit/process/part_referral.cgi index 94d29c40e..998cd93db 100755 --- a/htdocs/edit/process/part_referral.cgi +++ b/htdocs/edit/process/part_referral.cgi @@ -1,6 +1,6 @@ #!/usr/bin/perl -Tw # -# $Id: part_referral.cgi,v 1.2 1998-12-17 08:40:25 ivan Exp $ +# $Id: part_referral.cgi,v 1.3 1998-12-30 23:03:30 ivan Exp $ # # ivan@sisd.com 98-feb-23 # @@ -10,7 +10,10 @@ # lose background, FS::CGI ivan@sisd.com 98-sep-2 # # $Log: part_referral.cgi,v $ -# Revision 1.2 1998-12-17 08:40:25 ivan +# Revision 1.3 1998-12-30 23:03:30 ivan +# bugfixes; fields isn't exported by derived classes +# +# Revision 1.2 1998/12/17 08:40:25 ivan # s/CGI::Request/CGI.pm/; etc # @@ -18,8 +21,8 @@ use strict; use CGI; use CGI::Carp qw(fatalsToBrowser); use FS::UID qw(cgisuidsetup); -use FS::Record qw(qsearchs); -use FS::part_referral qw(fields); +use FS::Record qw(qsearchs fields); +use FS::part_referral; use FS::CGI qw(popurl eidiot); my($cgi)=new CGI; # create form object diff --git a/htdocs/edit/process/part_svc.cgi b/htdocs/edit/process/part_svc.cgi index 0f67410ee..1298dbc4e 100755 --- a/htdocs/edit/process/part_svc.cgi +++ b/htdocs/edit/process/part_svc.cgi @@ -1,6 +1,6 @@ #!/usr/bin/perl -Tw # -# $Id: part_svc.cgi,v 1.3 1998-12-17 08:40:26 ivan Exp $ +# $Id: part_svc.cgi,v 1.4 1998-12-30 23:03:31 ivan Exp $ # # ivan@sisd.com 97-nov-14 # @@ -10,7 +10,10 @@ # lose background, FS::CGI ivan@sisd.com 98-sep-2 # # $Log: part_svc.cgi,v $ -# Revision 1.3 1998-12-17 08:40:26 ivan +# Revision 1.4 1998-12-30 23:03:31 ivan +# bugfixes; fields isn't exported by derived classes +# +# Revision 1.3 1998/12/17 08:40:26 ivan # s/CGI::Request/CGI.pm/; etc # # Revision 1.2 1998/11/21 06:43:08 ivan @@ -21,8 +24,8 @@ use strict; use CGI; use CGI::Carp qw(fatalsToBrowser); use FS::UID qw(cgisuidsetup); -use FS::Record qw(qsearchs); -use FS::part_svc qw(fields); +use FS::Record qw(qsearchs fields); +use FS::part_svc; use FS::CGI qw(eidiot popurl); my($cgi)=new CGI; # create form object diff --git a/htdocs/edit/process/svc_acct_pop.cgi b/htdocs/edit/process/svc_acct_pop.cgi index 89cc75c35..8b0e60835 100755 --- a/htdocs/edit/process/svc_acct_pop.cgi +++ b/htdocs/edit/process/svc_acct_pop.cgi @@ -1,6 +1,6 @@ #!/usr/bin/perl -Tw # -# $Id: svc_acct_pop.cgi,v 1.2 1998-12-17 08:40:28 ivan Exp $ +# $Id: svc_acct_pop.cgi,v 1.3 1998-12-30 23:03:32 ivan Exp $ # # ivan@sisd.com 98-mar-8 # @@ -10,7 +10,10 @@ # lose background, FS::CGI ivan@sisd.com 98-sep-2 # # $Log: svc_acct_pop.cgi,v $ -# Revision 1.2 1998-12-17 08:40:28 ivan +# Revision 1.3 1998-12-30 23:03:32 ivan +# bugfixes; fields isn't exported by derived classes +# +# Revision 1.2 1998/12/17 08:40:28 ivan # s/CGI::Request/CGI.pm/; etc # @@ -18,8 +21,8 @@ use strict; use CGI; use CGI::Carp qw(fatalsToBrowser); use FS::UID qw(cgisuidsetup); -use FS::Record qw(qsearch qsearchs); -use FS::svc_acct_pop qw(fields); +use FS::Record qw(qsearch qsearchs fields); +use FS::svc_acct_pop; use FS::CGI qw(popurl eidiot); my($cgi)=new CGI; # create form object diff --git a/htdocs/edit/svc_acct.cgi b/htdocs/edit/svc_acct.cgi index dc9f6e91a..edb4a684e 100755 --- a/htdocs/edit/svc_acct.cgi +++ b/htdocs/edit/svc_acct.cgi @@ -1,6 +1,6 @@ #!/usr/bin/perl -Tw # -# $Id: svc_acct.cgi,v 1.3 1998-12-17 06:17:08 ivan Exp $ +# $Id: svc_acct.cgi,v 1.4 1998-12-30 23:03:22 ivan Exp $ # # Usage: svc_acct.cgi {svcnum} | pkgnum{pkgnum}-svcpart{svcpart} # http://server.name/path/svc_acct.cgi? {svcnum} | pkgnum{pkgnum}-svcpart{svcpart} @@ -18,7 +18,10 @@ # use conf/shells and dbdef username length ivan@sisd.com 98-jul-13 # # $Log: svc_acct.cgi,v $ -# Revision 1.3 1998-12-17 06:17:08 ivan +# Revision 1.4 1998-12-30 23:03:22 ivan +# bugfixes; fields isn't exported by derived classes +# +# Revision 1.3 1998/12/17 06:17:08 ivan # fix double // in relative URLs, s/CGI::Base/CGI/; # @@ -28,8 +31,8 @@ use CGI; use CGI::Carp qw(fatalsToBrowser); use FS::UID qw(cgisuidsetup getotaker); use FS::CGI qw(header popurl); -use FS::Record qw(qsearch qsearchs); -use FS::svc_acct qw(fields); +use FS::Record qw(qsearch qsearchs fields); +use FS::svc_acct; use FS::Conf; my($cgi) = new CGI; diff --git a/htdocs/edit/svc_acct_sm.cgi b/htdocs/edit/svc_acct_sm.cgi index 7a1b946e0..be5350d84 100755 --- a/htdocs/edit/svc_acct_sm.cgi +++ b/htdocs/edit/svc_acct_sm.cgi @@ -1,6 +1,6 @@ #!/usr/bin/perl -Tw # -# $Id: svc_acct_sm.cgi,v 1.4 1998-12-23 02:58:45 ivan Exp $ +# $Id: svc_acct_sm.cgi,v 1.5 1998-12-30 23:03:24 ivan Exp $ # # Usage: svc_acct_sm.cgi {svcnum} | pkgnum{pkgnum}-svcpart{svcpart} # http://server.name/path/svc_acct_sm.cgi? {svcnum} | pkgnum{pkgnum}-svcpart{svcpart} @@ -35,7 +35,10 @@ # /var/spool/freeside/conf/domain ivan@sisd.com 98-jul-26 # # $Log: svc_acct_sm.cgi,v $ -# Revision 1.4 1998-12-23 02:58:45 ivan +# Revision 1.5 1998-12-30 23:03:24 ivan +# bugfixes; fields isn't exported by derived classes +# +# Revision 1.4 1998/12/23 02:58:45 ivan # $cgi->keywords instead of $cgi->query_string # # Revision 1.3 1998/12/17 06:17:11 ivan @@ -51,8 +54,8 @@ use CGI; use CGI::Carp qw(fatalsToBrowser); use FS::UID qw(cgisuidsetup); use FS::CGI qw(header popurl); -use FS::Record qw(qsearch qsearchs); -use FS::svc_acct_sm qw(fields); +use FS::Record qw(qsearch qsearchs fields); +use FS::svc_acct_sm; use FS::Conf; my($cgi) = new CGI; diff --git a/htdocs/edit/svc_domain.cgi b/htdocs/edit/svc_domain.cgi index 6373ebb48..2937ccea0 100755 --- a/htdocs/edit/svc_domain.cgi +++ b/htdocs/edit/svc_domain.cgi @@ -1,6 +1,6 @@ #!/usr/bin/perl -Tw # -# $Id: svc_domain.cgi,v 1.4 1998-12-23 03:00:16 ivan Exp $ +# $Id: svc_domain.cgi,v 1.5 1998-12-30 23:03:25 ivan Exp $ # # Usage: svc_domain.cgi pkgnum{pkgnum}-svcpart{svcpart} # http://server.name/path/svc_domain.cgi?pkgnum{pkgnum}-svcpart{svcpart} @@ -17,7 +17,10 @@ # no GOV in instructions ivan@sisd.com 98-jul-17 # # $Log: svc_domain.cgi,v $ -# Revision 1.4 1998-12-23 03:00:16 ivan +# Revision 1.5 1998-12-30 23:03:25 ivan +# bugfixes; fields isn't exported by derived classes +# +# Revision 1.4 1998/12/23 03:00:16 ivan # $cgi->keywords instead of $cgi->query_string # # Revision 1.3 1998/12/17 06:17:12 ivan @@ -33,8 +36,8 @@ use CGI; use CGI::Carp qw(fatalsToBrowser); use FS::UID qw(cgisuidsetup getotaker); use FS::CGI qw(header popurl); -use FS::Record qw(qsearch qsearchs); -use FS::svc_domain qw(fields); +use FS::Record qw(qsearch qsearchs fields); +use FS::svc_domain; my($cgi) = new CGI; &cgisuidsetup($cgi); diff --git a/htdocs/view/cust_bill.cgi b/htdocs/view/cust_bill.cgi index 06fd2d76d..80aab187f 100755 --- a/htdocs/view/cust_bill.cgi +++ b/htdocs/view/cust_bill.cgi @@ -1,6 +1,6 @@ #!/usr/bin/perl -Tw # -# $Id: cust_bill.cgi,v 1.3 1998-12-23 03:07:49 ivan Exp $ +# $Id: cust_bill.cgi,v 1.4 1998-12-30 23:03:33 ivan Exp $ # # Note: Should be run setuid freeside as user nobody. # @@ -25,7 +25,10 @@ # also print 'printed' field ivan@sisd.com 98-jul-10 # # $Log: cust_bill.cgi,v $ -# Revision 1.3 1998-12-23 03:07:49 ivan +# Revision 1.4 1998-12-30 23:03:33 ivan +# bugfixes; fields isn't exported by derived classes +# +# Revision 1.3 1998/12/23 03:07:49 ivan # $cgi->keywords instead of $cgi->query_string # # Revision 1.2 1998/12/17 09:57:20 ivan @@ -37,7 +40,7 @@ use IO::File; use CGI; use CGI::Carp qw(fatalsToBrowser); use FS::UID qw(cgisuidsetup); -use FS::CGI qw(header popurl); +use FS::CGI qw(header popurl menubar); use FS::Record qw(qsearchs); use FS::cust_bill; diff --git a/htdocs/view/cust_main.cgi b/htdocs/view/cust_main.cgi index cc6983d70..8e6145519 100755 --- a/htdocs/view/cust_main.cgi +++ b/htdocs/view/cust_main.cgi @@ -1,6 +1,6 @@ #!/usr/bin/perl -Tw # -# $Id: cust_main.cgi,v 1.6 1998-12-23 02:42:33 ivan Exp $ +# $Id: cust_main.cgi,v 1.7 1998-12-30 23:03:34 ivan Exp $ # # Usage: cust_main.cgi custnum # http://server.name/path/cust_main.cgi?custnum @@ -33,7 +33,10 @@ # lose background, FS::CGI ivan@sisd.com 98-sep-2 # # $Log: cust_main.cgi,v $ -# Revision 1.6 1998-12-23 02:42:33 ivan +# Revision 1.7 1998-12-30 23:03:34 ivan +# bugfixes; fields isn't exported by derived classes +# +# Revision 1.6 1998/12/23 02:42:33 ivan # remove double '/' in link urls # # Revision 1.5 1998/12/23 02:36:28 ivan @@ -247,7 +250,7 @@ print ""; print qq!

Payment History!, qq!
!, qq!Click on invoice to view invoice/enter payment.
!, - qq!!, + qq!!, qq!Post Credit / Refund

!; #get payment history @@ -262,7 +265,7 @@ my($bill); foreach $bill (@bills) { my($bref)=$bill->hashref; push @history, - $bref->{_date} . qq!\t{invnum} . qq!">Invoice #! . $bref->{invnum} . qq! (Balance \$! . $bref->{owed} . qq!)\t! . $bref->{charged} . qq!\t\t\t!; -- 2.11.0