From d1384806285ae03e8132ad2844d376ff64bd5e6d Mon Sep 17 00:00:00 2001 From: mark Date: Tue, 12 Apr 2011 01:25:14 +0000 Subject: [PATCH] fix batch closure, #12351 --- FS/FS/pay_batch.pm | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/FS/FS/pay_batch.pm b/FS/FS/pay_batch.pm index 850335e84..79c47498a 100644 --- a/FS/FS/pay_batch.pm +++ b/FS/FS/pay_batch.pm @@ -383,20 +383,21 @@ sub import_results { } # foreach (@all_values) + my $close = 1; if ( defined($close_condition) ) { # Allow the module to decide whether to close the batch. # $close_condition can also die() to abort the whole import. - my $close = eval { $close_condition->($self) }; + $close = eval { $close_condition->($self) }; if ( $@ ) { $dbh->rollback; die $@; } - if ( $close ) { - my $error = $self->set_status('R'); - if ( $error ) { - $dbh->rollback if $oldAutoCommit; - return $error; - } + } + if ( $close ) { + my $error = $self->set_status('R'); + if ( $error ) { + $dbh->rollback if $oldAutoCommit; + return $error; } } -- 2.11.0